Skip to content

feat(css): Add ruby-overhang property #40041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Conversation

bsmth
Copy link
Member

@bsmth bsmth commented Jun 23, 2025

Description

This PR adds a page for the CSS ruby-overhang property.

  • The interactive example is not being reloaded when switching options/choices. Needs investigation.

TODO:

Motivation

We're missing a docs page for it.

Additional details

I took a look through relnotes from Jen Simmons' for Safari 18.2 which has some good examples:

@github-actions github-actions bot added Content:CSS Cascading Style Sheets docs size/m [PR only] 51-500 LoC changed labels Jun 23, 2025
Copy link
Contributor

github-actions bot commented Jun 23, 2025

Preview URLs

(comment last updated: 2025-06-26 07:53:19)

```

```css interactive-example-choice
ruby-overhang: none;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this doesn't work because we're animating the values? I can't figure out why this works:

```css interactive-example-choice
ruby-overhang: auto;
ruby-position: over;
```

```css interactive-example-choice
ruby-overhang: none;
ruby-position: under;
```

But it doesn't work after removing ruby-position

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the iframe is not being reloaded, in other words, if you change the default value for interactive-example-choice to be either auto or none, it works on page load.

@bsmth
Copy link
Member Author

bsmth commented Jun 23, 2025

Anyone from @mdn/ja-content interested in having a look sometime? Not urgent! :)

@bsmth bsmth marked this pull request as ready for review June 26, 2025 07:55
@bsmth bsmth requested a review from a team as a code owner June 26, 2025 07:55
@bsmth bsmth requested review from estelle and removed request for a team June 26, 2025 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:CSS Cascading Style Sheets docs size/m [PR only] 51-500 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant