Only use *.example and example.com as example domains #41428
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Josh-Cena
requested review from
chrisdavidmills,
hamishwillee,
rebloor and
wbamberg
and removed request for
a team
github-actions
bot
added
Content:CSS
Josh-Cena
removed request for
a team,
chrisdavidmills,
hamishwillee and
rebloor
bsmth
reviewed
Oct 8, 2025
| Access-Control-Request-Method: GET | ||
| Access-Control-Request-Headers: content-type,x-requested-with | ||
| Origin: https://foo.bar.org | ||
| Origin: https://example.com |
There was a problem hiding this comment.
Do you want to keep a subdomain here and the one below?
Suggested change
| Origin: https://example.com | |
| Origin: https://subdomain.example.com |
rebloor
reviewed
Oct 8, 2025
Comment on lines
+42
to
+43
| 1. You visit `a-shopping-site.example`, which uses `ad-tracker.example` to deliver its adverts on the web. `ad-tracker.example` sets a cookie associated with the `ad-tracker.example` domain. While you are on `a-shopping-site.example`, `ad-tracker.example` receives information about the products you browse. | ||
| 2. You now visit `a-news-site.example` that uses `ad-tracker.example` to deliver adverts. `ad-tracker.example` read its cookie and use the information collected from `a-shopping-site.example` to decide which adverts to display to you. |
There was a problem hiding this comment.
@dotproto any thoughts on this? Does it make the examples to unrealistic?
There was a problem hiding this comment.
FWIW I don't much like .example as a TLD, as it is so unexpected (same applies in the XSS guide). But if it's the consensus, I would go along with it.
There was a problem hiding this comment.
+1, this was also my initial read here, but I think it's the right call.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove a lot of example domains that may happen to be valid, fixing #39865. It is impossible to find all such examples, but I found a good bunch.