-
Notifications
You must be signed in to change notification settings - Fork 22.9k
Editorial review: add getDisplayMedia() windowAudio option #41440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Editorial review: add getDisplayMedia() windowAudio option #41440
Conversation
|
Preview URLs (comment last updated: 2025-10-09 10:54:36) |
beaufortfrancois
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with nits
| - `windowAudio` {{Experimental_Inline}} {{optional_inline}} | ||
| - : An enumerated value that hints to the browser what audio sharing option the user should be presented with alongside `window` sharing options. Possible values are: | ||
| - `exclude`: Hints that audio should not be shareable when a window sharing option is chosen. | ||
| - `window`: Hints that when a window sharing option is chosen, only audio originating from that window should be shared. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You may want to add a note saying it's working in Chrome for Windows OS only IIRC. @guidou would know more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, OK. This detail would be better added to the compat data. I'll fire up my Windows testing machine and test it out there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for helping me figure this out!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hrm, I've tested it on Windows (in Chrome and Edge, Stable and Canary), and it doesn't seem to work there either. I'll leave the compat data as-is for now.
Co-authored-by: François Beaufort <[email protected]>
Elchi3
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Co-authored-by: Florian Scholz <[email protected]>
Description
Chrome/Edge desktop 141 add support for the
getDisplayMedia()windowAudiooption. See https://chromestatus.com/feature/5072779506089984.This PR adds a mention of it in the documentation. Note that in testing, the
windowvalue didn't seem to work. See also the compat data PR: mdn/browser-compat-data#28130Motivation
Additional details
Related issues and pull requests