Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: rename inset-area to position-area #769

Merged
merged 2 commits into from
Oct 18, 2024

Conversation

skyclouds2001
Copy link
Contributor

@skyclouds2001 skyclouds2001 commented Oct 6, 2024

Description

Motivation

Additional details

spec at https://drafts.csswg.org/css-anchor-position-1/#position-area

see also mdn/content#35700, and the spec update w3c/csswg-drafts#10592

Related issues and pull requests

Copy link
Contributor

github-actions bot commented Oct 6, 2024

It looks like this is your first pull request. 🎉 Thank you for your contribution! One of the project maintainers will triage and assign the pull request for review. We appreciate your patience. To safeguard the health of the project, please take a moment to read our code of conduct.

@skyclouds2001 skyclouds2001 changed the title Add syntax info for position-area Rename inert-area to position-area Oct 6, 2024
@skyclouds2001 skyclouds2001 changed the title Rename inert-area to position-area Rename inset-area to position-area Oct 6, 2024
@skyclouds2001 skyclouds2001 marked this pull request as ready for review October 7, 2024 12:06
@skyclouds2001 skyclouds2001 requested a review from a team as a code owner October 7, 2024 12:06
@skyclouds2001 skyclouds2001 requested review from pepelsbey and removed request for a team October 7, 2024 12:06
@skyclouds2001 skyclouds2001 changed the title Rename inset-area to position-area feat: rename inset-area to position-area Oct 12, 2024
Copy link
Member

@pepelsbey pepelsbey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you :)

@pepelsbey pepelsbey merged commit d2b8857 into mdn:main Oct 18, 2024
3 checks passed
@skyclouds2001 skyclouds2001 deleted the position-area branch October 18, 2024 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants