Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(css): Update group field for css selectors #965

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

skyclouds2001
Copy link
Contributor

@skyclouds2001 skyclouds2001 commented Apr 3, 2025

Description

to make the group field really represents which module the feature is defined

Motivation

Additional details

Related issues and pull requests

@skyclouds2001 skyclouds2001 marked this pull request as ready for review April 3, 2025 18:27
@skyclouds2001 skyclouds2001 requested a review from a team as a code owner April 3, 2025 18:27
@skyclouds2001 skyclouds2001 requested review from bsmth and removed request for a team April 3, 2025 18:27
@@ -146,25 +130,20 @@
":active-view-transition": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bsmth
Copy link
Member

bsmth commented Apr 7, 2025

Thanks a lot. In general, this is technically correct, so I would be curious to get another opinion again on whether:

make the group field really represents which module the feature is defined

is what consumers expect as opposed to these returned when someone is looking for a list of pseudo-classes or pseudo-elements. "Defined in" versus "can be classed as" is a good distinction to double-check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants