-
Notifications
You must be signed in to change notification settings - Fork 8.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: replace WebRTCSidebar
in ko
#10291
Conversation
Preview URLs (7 pages)
Flaws (53)Note! 1 document with no flaws that don't need to be listed. 🎉 URL:
URL:
URL:
URL:
URL:
URL:
External URLs (7)URL:
URL:
(comment last updated: 2022-12-10 14:28:47) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @notJoon !
Just a couple of comments: we should use APIRef
, not DefaultAPISidebar
for pages that are not under /api/webrtc_api.
Apart from that, the sidebar changes look good. The page type changes and code updates look good to me too. I didn't review anything else :).
files/ko/web/api/rtcpeerconnection/currentlocaldescription/index.md
Outdated
Show resolved
Hide resolved
change defaultAPISidebar Co-authored-by: wbamberg <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @notJoon , the sidebar changes look good to me!
files/ko/web/api/rtcpeerconnection/currentlocaldescription/index.md
Outdated
Show resolved
Hide resolved
files/ko/web/api/rtcpeerconnection/currentlocaldescription/index.md
Outdated
Show resolved
Hide resolved
files/ko/web/api/rtcpeerconnection/currentremotedescription/index.md
Outdated
Show resolved
Hide resolved
files/ko/web/api/webrtc_api/signaling_and_video_calling/index.md
Outdated
Show resolved
Hide resolved
Co-authored-by: A1lo <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for me too. Have a nice day everyone.
@notJoon 님 안녕하세요. yin1999님께서 리뷰주셨듯이 메타데이터 지침 에서 해당 내용 있어서 혹시 몰라 첨부 드렸습니다. 참고 부탁드립니다!
#10291 (comment) 는 반영 하지 않은 이유가 있으신지 궁금합니다.
시간 여유 괜찮으시다면 추후 다른 기여자 분들을 위해 한국 번역 가이드 지침에 기여주신 내용들 추가 부탁드립니다. (e.g. Just a couple of comments: we should use APIRef, not DefaultAPISidebar for pages that are not under /api/webrtc_api.)
그외 다른 사항들은 문제 없어보입니다. 고생 많으셨습니다. 기여해주셔서 감사합니다. 좋은 하루 보내세요 :)
Co-authored-by: A1lo <[email protected]>
@hochan222 빠진 코멘트는 의도한건 아니고 못 보고 지나친거 같습니다. 꼼꼼히 안봤더니 이런 일이 다 일어나네요. 확인해주셔서 감사드리며, 좋은 하루 보내시길 바랍니다 👍 |
Description
Removed
{{WebRTCSidebar}}
macros and changed to{{DefaultAPISidebar('WebRTC')}}
Additional details
page-type
,tags
which are missing in ko headerRelated issues and pull requests