Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: replace WebRTCSidebar in ko #10291

Merged
merged 5 commits into from
Dec 10, 2022
Merged

chore: replace WebRTCSidebar in ko #10291

merged 5 commits into from
Dec 10, 2022

Conversation

notJoon
Copy link
Contributor

@notJoon notJoon commented Nov 28, 2022

Description

Removed {{WebRTCSidebar}} macros and changed to {{DefaultAPISidebar('WebRTC')}}

Additional details

  • add header page-type, tags which are missing in ko header
  • fixable link flaws and typos are fixed

Related issues and pull requests

@notJoon notJoon requested a review from a team as a code owner November 28, 2022 13:02
@notJoon notJoon requested review from igy95 and removed request for a team November 28, 2022 13:02
@github-actions github-actions bot added the l10n-ko Issues related to Korean content. label Nov 28, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Nov 28, 2022

Preview URLs (7 pages)
Flaws (53)

Note! 1 document with no flaws that don't need to be listed. 🎉

URL: /ko/docs/Web/API/RTCPeerConnection/currentLocalDescription
Title: RTCPeerConnection.currentLocalDescription
Flaw count: 5

  • macros:
    • /ko/docs/Web/API/RTCPeerConnection/pendingLocalDescription does not exist but fell back to /en-US/docs/Web/API/RTCPeerConnection/pendingLocalDescription
    • /ko/docs/Web/API/RTCPeerConnection/pendingLocalDescription does not exist but fell back to /en-US/docs/Web/API/RTCPeerConnection/pendingLocalDescription
    • /ko/docs/Web/API/RTCPeerConnection/setRemoteDescription does not exist but fell back to /en-US/docs/Web/API/RTCPeerConnection/setRemoteDescription
    • /ko/docs/Web/API/RTCPeerConnection/remoteDescription does not exist but fell back to /en-US/docs/Web/API/RTCPeerConnection/remoteDescription
    • /ko/docs/Web/API/RTCPeerConnection/pendingRemoteDescription does not exist but fell back to /en-US/docs/Web/API/RTCPeerConnection/pendingRemoteDescription

URL: /ko/docs/Web/API/RTCPeerConnection/localDescription
Title: RTCPeerConnection.localDescription
Flaw count: 9

  • macros:
    • /ko/docs/Web/API/RTCPeerConnection/pendingLocalDescription does not exist but fell back to /en-US/docs/Web/API/RTCPeerConnection/pendingLocalDescription
    • This macro has been deprecated, and should be removed.
    • This macro has been deprecated, and should be removed.
    • /ko/docs/Web/API/RTCPeerConnection/pendingLocalDescription does not exist but fell back to /en-US/docs/Web/API/RTCPeerConnection/pendingLocalDescription
    • /ko/docs/Web/API/RTCPeerConnection/setRemoteDescription does not exist but fell back to /en-US/docs/Web/API/RTCPeerConnection/setRemoteDescription
    • and 2 more flaws omitted
  • broken_links:
    • Can use the English (en-US) link as a fallback
  • translation_differences:
    • Differences in the important macros (2 in common of 4 possible)

URL: /ko/docs/Web/API/RTCPeerConnection/currentRemoteDescription
Title: RTCPeerConnection.currentRemoteDescription
Flaw count: 8

  • macros:
    • /ko/docs/Web/API/RTCPeerConnection/setRemoteDescription does not exist but fell back to /en-US/docs/Web/API/RTCPeerConnection/setRemoteDescription
    • /ko/docs/Web/API/RTCPeerConnection/remoteDescription does not exist but fell back to /en-US/docs/Web/API/RTCPeerConnection/remoteDescription
    • /ko/docs/Web/API/RTCPeerConnection/setRemoteDescription does not exist but fell back to /en-US/docs/Web/API/RTCPeerConnection/setRemoteDescription
    • /ko/docs/Web/API/RTCPeerConnection/pendingRemoteDescription does not exist but fell back to /en-US/docs/Web/API/RTCPeerConnection/pendingRemoteDescription
    • /ko/docs/Web/API/RTCPeerConnection/remoteDescription does not exist but fell back to /en-US/docs/Web/API/RTCPeerConnection/remoteDescription
    • and 3 more flaws omitted

URL: /ko/docs/Web/API/WebRTC_API/adapter.js
Title: Improving compatibility using WebRTC adapter.js
Flaw count: 1

  • macros:
    • /ko/docs/Web/API/RTCPeerConnection/urls does not exist

URL: /ko/docs/Web/API/WebRTC_API/Using_data_channels
Title: WebRTC data channel 사용하기
Flaw count: 8

  • macros:
    • /ko/docs/Web/API/RTCDataChannel does not exist but fell back to /en-US/docs/Web/API/RTCDataChannel
    • This macro has been deprecated, and should be removed.
    • /ko/docs/Web/API/RTCDataChannel does not exist but fell back to /en-US/docs/Web/API/RTCDataChannel
    • /ko/docs/Web/API/RTCDataChannelInit/negotiated does not exist
    • /ko/docs/Web/API/RTCDataChannel/open_event does not exist but fell back to /en-US/docs/Web/API/RTCDataChannel/open_event
    • and 3 more flaws omitted

URL: /ko/docs/Web/API/WebRTC_API/Signaling_and_video_calling
Title: Signaling and video calling
Flaw count: 22

  • macros:
    • /ko/docs/Web/API/RTCPeerConnection/onicecandidate redirects to /ko/docs/Web/API/RTCPeerConnection/icecandidate_event
    • /ko/docs/Web/API/RTCPeerConnection/onaddstream does not exist but fell back to /en-US/docs/Web/API/RTCPeerConnection/addstream_event
    • /ko/docs/Web/API/RTCPeerConnection/onremovestream does not exist but fell back to /en-US/docs/Web/API/RTCPeerConnection/removestream_event
    • /ko/docs/Web/API/RTCPeerConnection/oniceconnectionstatechange does not exist but fell back to /en-US/docs/Web/API/RTCPeerConnection/iceconnectionstatechange_event
    • /ko/docs/Web/API/RTCPeerConnection/onicegatheringstatechange redirects to /ko/docs/Web/API/RTCPeerConnection/icegatheringstatechange_event
    • and 6 more flaws omitted
  • broken_links:
    • Can't resolve /docs/MDN/Contribute/Howto/Do_an_editorial_review
    • Can't resolve /ko/docs/Web/API/MediaElement/srcObject
    • Can't resolve /ko/docs/Web/Reference/Events/removestream
    • Can use the English (en-US) link as a fallback
    • Can't resolve /ko/docs/Web/API/WebRTC_API/Signaling_and_video_calling?document_saved=true#Receiving_new_streams
    • and 6 more flaws omitted
External URLs (7)

URL: /ko/docs/Web/API/WebRTC_API/adapter.js
Title: Improving compatibility using WebRTC adapter.js


URL: /ko/docs/Web/API/WebRTC_API/Signaling_and_video_calling
Title: Signaling and video calling

(comment last updated: 2022-12-10 14:28:47)

Copy link
Contributor

@wbamberg wbamberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @notJoon !

Just a couple of comments: we should use APIRef, not DefaultAPISidebar for pages that are not under /api/webrtc_api.

Apart from that, the sidebar changes look good. The page type changes and code updates look good to me too. I didn't review anything else :).

notJoon and others added 2 commits November 29, 2022 10:24
change defaultAPISidebar

Co-authored-by: wbamberg <[email protected]>
@notJoon
Copy link
Contributor Author

notJoon commented Nov 29, 2022

@wbamberg @nschonni
thanks for your reviewing! all changes are updated

Copy link
Contributor

@wbamberg wbamberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @notJoon , the sidebar changes look good to me!

Copy link
Member

@hochan222 hochan222 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for me too. Have a nice day everyone.


@notJoon 님 안녕하세요. yin1999님께서 리뷰주셨듯이 메타데이터 지침 에서 해당 내용 있어서 혹시 몰라 첨부 드렸습니다. 참고 부탁드립니다!

#10291 (comment) 는 반영 하지 않은 이유가 있으신지 궁금합니다.

시간 여유 괜찮으시다면 추후 다른 기여자 분들을 위해 한국 번역 가이드 지침에 기여주신 내용들 추가 부탁드립니다. (e.g. Just a couple of comments: we should use APIRef, not DefaultAPISidebar for pages that are not under /api/webrtc_api.)

그외 다른 사항들은 문제 없어보입니다. 고생 많으셨습니다. 기여해주셔서 감사합니다. 좋은 하루 보내세요 :)

@notJoon
Copy link
Contributor Author

notJoon commented Dec 10, 2022

@hochan222 빠진 코멘트는 의도한건 아니고 못 보고 지나친거 같습니다. 꼼꼼히 안봤더니 이런 일이 다 일어나네요. 확인해주셔서 감사드리며, 좋은 하루 보내시길 바랍니다 👍

@hochan222 hochan222 merged commit 891f903 into mdn:main Dec 10, 2022
@notJoon notJoon deleted the remove-webrtc-ko branch December 10, 2022 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
l10n-ko Issues related to Korean content.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants