ko replace old spec and compat macro #11691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Preview URLs (197 pages)
Flaws (2876)Note! 18 documents with no flaws that don't need to be listed. 🎉 URL:
URL:
No first query argument or 'browser-compat' front-matter value passed`
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
No first query argument or 'browser-compat' front-matter value passed`
URL:
No first query argument or 'browser-compat' front-matter value passed`
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
|
|
오! 대단합니다! 이걸 해내셨군요! |
hochan222
approved these changes
Feb 19, 2023
8 tasks
Comment on lines
39
to
+49
| ### Clipboard | ||
|
|
||
| {{Compat("api.Clipboard")}} | ||
| {{Compat}} | ||
|
|
||
| ### ClipboardEvent | ||
|
|
||
| {{Compat("api.ClipboardEvent")}} | ||
| {{Compat}} | ||
|
|
||
| ### ClipboardItem | ||
|
|
||
| {{Compat("api.ClipboardItem")}} | ||
| {{Compat}} |
There was a problem hiding this comment.
A little after-merge review: sections like this with multiple interfaces should actually just be replaced with a single {{Compat}} call -- the macro (well, "macro") has been enhanced to do this for us if multiple BCD keys are given in the frontmatter keys!
There was a problem hiding this comment.
What a nice catch! Why didn't I think there would be more than one Compat on a page?
There was a problem hiding this comment.
There's a lot of little details like this left over from the old wiki days, and it's hard to catch them all -- I had just found out that some {{Specifications}} macro calls can also have arguments that need to be removed, apparently, and I hadn't even thought about that until stumbling across it in the Spanish locale!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#11594 거의 다 확인한것 같습니다. Specifications 또는 명세서 헤드라인을 거의 다 확인 해보았지만, 한 번 더 검토가 있었으면 좋겠습니다.