Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zh: Remove arguments to {{Specifications}} macros #11876

Merged
merged 1 commit into from
Feb 24, 2023
Merged

zh: Remove arguments to {{Specifications}} macros #11876

merged 1 commit into from
Feb 24, 2023

Conversation

queengooborg
Copy link
Collaborator

This PR performs the last little bits needed to complete #11594 for the Chinese locales.

@queengooborg queengooborg requested a review from a team as a code owner February 24, 2023 10:54
@queengooborg queengooborg requested review from yin1999 and removed request for a team February 24, 2023 10:54
@github-actions github-actions bot added the l10n-zh Issues related to Chinese content. label Feb 24, 2023
Copy link
Member

@yin1999 yin1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @queengooborg!

@yin1999 yin1999 merged commit cb8aea8 into main Feb 24, 2023
@yin1999 yin1999 deleted the zh/specs branch February 24, 2023 10:56
@github-actions
Copy link
Contributor

Preview URLs (6 pages)
Flaws (49)

URL: /zh-CN/docs/Web/CSS/column-gap
Title: column-gap
Flaw count: 2

  • broken_links:
    • Can use the English (en-US) link as a fallback
  • translation_differences:
    • Differences in the important macros (5 in common of 11 possible)

URL: /zh-CN/docs/Web/CSS/row-gap
Title: row-gap (grid-row-gap)
Flaw count: 1

  • translation_differences:
    • Differences in the important macros (5 in common of 9 possible)

URL: /zh-CN/docs/Web/CSS/gap
Title: gap (grid-gap)
Flaw count: 1

  • translation_differences:
    • Differences in the important macros (5 in common of 11 possible)

URL: /zh-CN/docs/Web/API/Canvas_API
Title: Canvas
Flaw count: 17

  • macros:
    • /zh-CN/docs/Web/API/CanvasImageSource redirects to /zh-CN/docs/Web/API/CanvasRenderingContext2D
    • /zh-CN/docs/Web/API/RenderingContext does not exist
    • /zh-CN/docs/Web/API/CanvasCaptureMediaStream redirects to /zh-CN/docs/Web/API/CanvasCaptureMediaStreamTrack
  • broken_links:
    • Can't resolve /zh-CN/docs/Web/WebGL
    • Can't resolve /zh-CN/docs/Web/WebGL
    • Can't resolve /zh-CN/docs/Web/Guide/HTML/Canvas_tutorial
    • Can't resolve /zh-CN/Add-ons/Code_snippets/Canvas
    • Is currently http:// but can become https://
    • and 8 more flaws omitted
  • translation_differences:
    • Differences in the important macros (2 in common of 5 possible)

URL: /zh-CN/docs/Web/JavaScript/Reference/Classes/Private_class_fields
Title: 类私有域
Flaw count: 1

  • broken_links:
    • Can use the English (en-US) link as a fallback

URL: /zh-TW/docs/Web/API/Canvas_API
Title: Canvas API
Flaw count: 27

  • macros:
    • /zh-TW/docs/Web/API/CanvasRenderingContext2D/fillRect does not exist but fell back to /en-US/docs/Web/API/CanvasRenderingContext2D/fillRect
    • /zh-TW/docs/Web/API/CanvasGradient does not exist but fell back to /en-US/docs/Web/API/CanvasGradient
    • /zh-TW/docs/Web/API/CanvasPattern does not exist but fell back to /en-US/docs/Web/API/CanvasPattern
    • /zh-TW/docs/Web/API/ImageBitmap does not exist but fell back to /en-US/docs/Web/API/ImageBitmap
    • /zh-TW/docs/Web/API/ImageData does not exist but fell back to /en-US/docs/Web/API/ImageData
    • and 3 more flaws omitted
  • broken_links:
    • Can't resolve /zh-TW/docs/HTML
    • Can't resolve /zh-TW/docs/JavaScript
    • Can't resolve /zh-TW/Firefox_1.5_for_developers
    • Is currently http:// but can become https://
    • Can't resolve /zh-TW/docs/Web/WebGL
    • and 13 more flaws omitted
  • translation_differences:
    • Differences in the important macros (2 in common of 5 possible)

@yin1999
Copy link
Member

yin1999 commented Feb 24, 2023

Hi @queengooborg, I just notice that after we migrating to ESM. The CI in translated-content is slower. This step just spent more time than before.

@queengooborg
Copy link
Collaborator Author

Hi @queengooborg, I just notice that after we migrating to ESM. The CI in translated-content is slower. This step just spent more time than before.

I think this is due to the fact that Yari isn't using async nearly as much as it should, and synchronous file reading is one of the biggest bottlenecks for NodeJS scripts.

Would you mind opening an issue in Yari regarding that?

@yin1999
Copy link
Member

yin1999 commented Feb 24, 2023

Would you mind opening an issue in Yari regarding that?

Filled in mdn/yari#8301

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
l10n-zh Issues related to Chinese content.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants