Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ko] Update: How to structure a web form #14002

Merged
merged 7 commits into from
Aug 2, 2023

Conversation

soorokim
Copy link
Contributor

@soorokim soorokim commented Jul 2, 2023

Description

how to structure a web from 부분의 최신화를 진행했습니다.

Motivation

한글문서가 표시되지 않던 이슈를 확인 하다
해당 문서에서 오류가 나는것을 발견하고 최신화를 진행했습니다.

Additional details

The paragraph at the top states a rule for required elements. The rule must be included before it is used so that sighted users and users of assistive technologies such as screen readers can learn what it means before they encounter a required element. While this helps inform users what an asterisk means, it can not be relied upon. A screen reader will speak an asterisk as "star" when encountered. When hovered by a sighted mouse user, "required" should appear, which is achieved by use of the title attribute. Titles being read aloud depends on the screen reader's settings, so it is more reliable to also include the aria-label attribute, which is always read by screen readers.

문장을 해석하면서 beforestar, required 에 강조표시를 위해 따옴표를 사용했습니다.

@soorokim soorokim requested a review from a team as a code owner July 2, 2023 03:25
@soorokim soorokim requested review from sunhpark42 and removed request for a team July 2, 2023 03:25
@github-actions github-actions bot added the l10n-ko Issues related to Korean content. label Jul 2, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jul 2, 2023

Preview URLs

Flaws (113)

Note! 1 document with no flaws that don't need to be listed. 🎉

URL: /ko/docs/Learn/Forms/How_to_structure_a_web_form
Title: HTML 폼 구성 방법
Flaw count: 113

  • macros:
    • /ko/docs/Learn/HTML/Introduction_to_HTML/Structuring_a_page_of_content does not exist but fell back to /en-US/docs/Learn/HTML/Introduction_to_HTML/Structuring_a_page_of_content
    • /ko/docs/Learn/HTML/Multimedia_and_embedding/Video_and_audio_content does not exist but fell back to /en-US/docs/Learn/HTML/Multimedia_and_embedding/Video_and_audio_content
    • /ko/docs/Learn/HTML/Multimedia_and_embedding/Adding_vector_graphics_to_the_Web does not exist but fell back to /en-US/docs/Learn/HTML/Multimedia_and_embedding/Adding_vector_graphics_to_the_Web
    • /ko/docs/Learn/HTML/Multimedia_and_embedding/Mozilla_splash_page does not exist but fell back to /en-US/docs/Learn/HTML/Multimedia_and_embedding/Mozilla_splash_page
    • /ko/docs/Learn/HTML/Tables/Basics does not exist but fell back to /en-US/docs/Learn/HTML/Tables/Basics
    • and 102 more flaws omitted
  • broken_links:
    • Can use the English (en-US) link as a fallback
    • Can use the English (en-US) link as a fallback
    • Can use the English (en-US) link as a fallback
    • Can use the English (en-US) link as a fallback
    • Can use the English (en-US) link as a fallback
    • and 1 more flaws omitted
External URLs (7)

URL: /ko/docs/Learn/Forms/How_to_structure_a_web_form
Title: HTML 폼 구성 방법

(comment last updated: 2023-08-02 15:58:39)

Copy link
Contributor

@sunhpark42 sunhpark42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

안녕하세요 @soorokim 님, 리뷰가 늦어 정말로 죄송합니다. 🙇‍♀️
수정이 필요한 부분에 대해 코멘트 남겨두었습니다. 확인 부탁드립니다.
기여 감사합니다.🙏

@soorokim
Copy link
Contributor Author

@sunhpark42 @hochan222 수정 완료했습니다!

@soorokim soorokim force-pushed the update/how_to_structure_a_web_form branch from 012f96d to a40514c Compare July 30, 2023 23:42
@github-actions github-actions bot added the merge conflicts 🚧 This pull request has merge conflicts that must be resolved. label Jul 31, 2023
@github-actions
Copy link
Contributor

This pull request has merge conflicts that must be resolved before it can be merged.

@soorokim soorokim requested review from a team as code owners August 1, 2023 02:20
@soorokim soorokim requested review from dynamis and jasonren0403 and removed request for a team August 1, 2023 02:20
@github-actions github-actions bot added l10n-ja Issues related to Japanese content. l10n-zh Issues related to Chinese content. system Infrastructure and configuration for the project merge conflicts 🚧 This pull request has merge conflicts that must be resolved. and removed merge conflicts 🚧 This pull request has merge conflicts that must be resolved. labels Aug 1, 2023
@soorokim soorokim force-pushed the update/how_to_structure_a_web_form branch from 656f42b to a40514c Compare August 1, 2023 02:31
@github-actions github-actions bot added merge conflicts 🚧 This pull request has merge conflicts that must be resolved. and removed l10n-ja Issues related to Japanese content. l10n-zh Issues related to Chinese content. system Infrastructure and configuration for the project labels Aug 1, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 1, 2023

This pull request has merge conflicts that must be resolved before it can be merged.

@github-actions github-actions bot removed the merge conflicts 🚧 This pull request has merge conflicts that must be resolved. label Aug 1, 2023
@soorokim soorokim requested a review from hochan222 August 2, 2023 03:26
Copy link
Member

@hochan222 hochan222 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생 많으셨습니다! 좋은 하루 보내세요 :)

@hochan222 hochan222 removed request for a team, dynamis and jasonren0403 August 2, 2023 15:51
@hochan222 hochan222 enabled auto-merge (squash) August 2, 2023 15:52
@hochan222 hochan222 disabled auto-merge August 2, 2023 15:53
@hochan222 hochan222 enabled auto-merge (squash) August 2, 2023 15:54
@hochan222 hochan222 merged commit 93d9328 into mdn:main Aug 2, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
l10n-ko Issues related to Korean content.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants