Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[zh-CN] sync Getting started part of web-ext #14030

Merged
merged 8 commits into from
Jul 5, 2023
Merged

[zh-CN] sync Getting started part of web-ext #14030

merged 8 commits into from
Jul 5, 2023

Conversation

uiolee
Copy link
Contributor

@uiolee uiolee commented Jul 4, 2023

Description

  • Synchronize with content
    • Mainly to add missing text.
    • keep their structure the same.
    • correct outdated links.

Motivation

Some articles are missing something compared to CONTENT. I don't think readers want to view both versions of the article and compare them carefully. I think an incomplete document is incompetent. So I added these contents from CONTENT to our Chinese documentation, although they have not been translated yet.

@uiolee uiolee requested a review from a team as a code owner July 4, 2023 05:47
@uiolee uiolee requested review from yin1999 and removed request for a team July 4, 2023 05:47
@github-actions github-actions bot added the l10n-zh Issues related to Chinese content. label Jul 4, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jul 4, 2023

Preview URLs (6 pages)
Flaws (39)

Note! 2 documents with no flaws that don't need to be listed. 🎉

URL: /zh-CN/docs/Mozilla/Add-ons/WebExtensions/Your_first_WebExtension
Title: 你的第一个拓展
Flaw count: 19

  • broken_links:
    • Can't resolve /zh-CN/Add-ons/WebExtensions/manifest.json/manifest_version
    • Can't resolve /zh-CN/Add-ons/WebExtensions/manifest.json/name
    • Can't resolve /zh-CN/Add-ons/WebExtensions/manifest.json/version
    • Can't resolve /zh-CN/Add-ons/WebExtensions/manifest.json/description
    • Can't resolve /zh-CN/Add-ons/WebExtensions/manifest.json/icons
    • and 14 more flaws omitted

URL: /zh-CN/docs/Mozilla/Add-ons/WebExtensions/What_are_WebExtensions
Title: 扩展是什么?
Flaw count: 1

  • broken_links:
    • Can't resolve /zh-CN/docs/Mozilla/Firefox/Multiprocess_Firefox

URL: /zh-CN/docs/Mozilla/Add-ons/WebExtensions/Anatomy_of_a_WebExtension
Title: 扩展剖析
Flaw count: 10

  • broken_links:
    • No need for the pathname in anchor links if it's the same page
    • No need for the pathname in anchor links if it's the same page
    • No need for the pathname in anchor links if it's the same page
    • No need for the pathname in anchor links if it's the same page
    • Can use the English (en-US) link as a fallback
    • and 5 more flaws omitted

URL: /zh-CN/docs/Mozilla/Add-ons/WebExtensions/Your_second_WebExtension
Title: 你的第二个 WebExtension
Flaw count: 9

  • broken_links:
    • Can't resolve /zh-CN/docs/Mozilla/Tech/XUL/Attribute/description
    • Can't resolve /zh-CN/Add-ons/WebExtensions/manifest.json/homepage_url
    • Can't resolve /zh-CN/Add-ons/WebExtensions/manifest.json/icons
    • Can't resolve /zh-CN/Add-ons/WebExtensions/manifest.json/permissions#activeTab_permission
    • Can't resolve /zh-CN/Add-ons/WebExtensions/Debugging
    • and 4 more flaws omitted
External URLs (14)

URL: /zh-CN/docs/Mozilla/Add-ons/WebExtensions/Examples
Title: 扩展示例


URL: /zh-CN/docs/Mozilla/Add-ons/WebExtensions/Your_second_WebExtension
Title: 你的第二个 WebExtension


URL: /zh-CN/docs/Mozilla/Add-ons/WebExtensions/What_next_
Title: 下一步是什么?

(comment last updated: 2023-07-05 08:26:40)

Copy link
Member

@yin1999 yin1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @uiolee, please translate those English sentences. Do not add more English words in zh-CN translation. Thanks

@uiolee
Copy link
Contributor Author

uiolee commented Jul 4, 2023

Hi @yin1999 . My thought is to pull content first, and then our readers and volunteers will see it. Then that content will be translated. Otherwise, we may ignore these content. I don't know if it fits the workflow.

@BSPR0002
Copy link
Contributor

BSPR0002 commented Jul 4, 2023

Hi @yin1999 . My thought is to pull content first, and then our readers and volunteers will see it. Then that content will be translated. Otherwise, we may ignore these content. I don't know if it fits the workflow.

IMO, this is most about the accessibility of the images, the absence of these contents in the original version may have been because they are not typically visible, leading to a lack of effort in translation. However, this is not considered good practice. Though you may not a chinese speaker, I think your approach is more like passing trouble to others.

@yin1999
Copy link
Member

yin1999 commented Jul 4, 2023

Hi @yin1999 . My thought is to pull content first, and then our readers and volunteers will see it. Then that content will be translated. Otherwise, we may ignore these content. I don't know if it fits the workflow.

The problem is, we have too many document that are not fully translated, and many documents are even fully in English. So I don't like the idea of directly adding English content to l10n. If a document is out-of-date (see the "last modified" at the bottom of page), it's better to report an issue rather than mixin English content, as Chrome could not perform the translation well with mixin content (The Chinese words in document may be "mis-translated", we just receive an issue about this).

@uiolee
Copy link
Contributor Author

uiolee commented Jul 4, 2023

Thank you for your answer. I think I understand now.

Copy link
Member

@yin1999 yin1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@yin1999 yin1999 merged commit 64e61e1 into mdn:main Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
l10n-zh Issues related to Chinese content.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants