Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate Prettier into workflows and commands (sync w/ upstream) #14195

Merged
merged 2 commits into from
Jul 14, 2023

Conversation

queengooborg
Copy link
Collaborator

This PR integrates Prettier into the GitHub Actions workflows, package.json commands, and Git precommit hooks. This synchronizes the workflows with mdn/content.

@queengooborg queengooborg requested a review from a team as a code owner July 14, 2023 09:22
@github-actions github-actions bot added the system Infrastructure and configuration for the project label Jul 14, 2023
@queengooborg queengooborg merged commit a82f094 into main Jul 14, 2023
@queengooborg queengooborg deleted the prettier-integrate branch July 14, 2023 09:54
@@ -40,7 +40,7 @@ jobs:

- name: Lint markdown files
run: |
yarn markdownlint-cli2-fix "**/${{ matrix.lang }}/**/*.md"
yarn fix:md "**/${{ matrix.lang }}/**/*.md"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would run on everything now, as the old way would use the glob, but the script target will not

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, right -- would you be down to submit a PR to fix that up? I'm currently in the middle of another project that I can't exactly git stash at the moment!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
system Infrastructure and configuration for the project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants