Replace double-dash with m-dash #14225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
queengooborg
requested review from
JuanVqz,
myshov,
yechoi42,
kenji-yamasaki,
SphinxKnight,
yin1999 and
josielrocha
and removed request for
a team
github-actions
bot
added
l10n-ja
|
Thanks for the review, @yin1999! Since there's additional grammatical changes being made here, I've decided to split the Chinese changes into its own PR so it can be reviewed and merged independently (and probably quicker)! |
queengooborg
force-pushed
the
lint/m-dash
branch
from
37db0e6
to
628023e
Compare
cw118
approved these changes
Jul 16, 2023
github-actions
bot
added
the
merge conflicts 🚧
|
This pull request has merge conflicts that must be resolved before it can be merged. |
github-actions
bot
removed
the
merge conflicts 🚧
|
Thanks for everyone's review, we're just waiting on @mdn/yari-content-ko's review now and then this can be merged! |
github-actions
bot
added
the
merge conflicts 🚧
|
This pull request has merge conflicts that must be resolved before it can be merged. |
github-actions
bot
removed
the
merge conflicts 🚧
|
Still haven't heard back from the Korean team -- I'm going to assume that this is alright for Korean, and if it isn't, we can revert it for Korean pages later! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces all instances of a double-dash (--) with an m-dash (—) throughout translated content. This synchronizes formatting with upstream.