-
Notifications
You must be signed in to change notification settings - Fork 8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure relative links have a starting slash #14226
Conversation
Preview URLs (66 pages)
Flaws (1281)Note! 10 documents with no flaws that don't need to be listed. 🎉 URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
/ru/docs/web/http/basics_of_http/mime_types references /ru/docs/web/media/formats/image_types, which does not exist`
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
unable to find an HTML element with an "id" of "properties" within /en-us/docs/web/javascript/reference/global_objects/weakset (derived from "en-US/Web/JavaScript/Reference/Global_Objects/WeakSet/prototype")`
unable to find an HTML element with an "id" of "methods" within /en-us/docs/web/javascript/reference/global_objects/weakset (derived from "en-US/Web/JavaScript/Reference/Global_Objects/WeakSet/prototype")`
URL:
URL:
URL:
External URLs (6)URL:
URL:
URL:
URL:
(comment last updated: 2023-07-17 23:05:02) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much! I notice some urls pointing to en-US
so heres is the correction
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you @queengooborg. But let's reference the localized documents :)
Co-authored-by: A1lo <[email protected]>
Co-authored-by: A1lo <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approve for ru
. Thanks ❤️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I allowed myself to push a commit that points to fr links in instead of en-US ones to hopefully avoid conflicts with the localized links PR (never mind, I did not notice that that PR does not modify these files). That being said, thank you for this @queengooborg !
files/fr/mozilla/add-ons/webextensions/sharing_objects_with_page_scripts/index.md
Outdated
Show resolved
Hide resolved
files/fr/web/progressive_web_apps/tutorials/js13kgames/loading/index.md
Outdated
Show resolved
Hide resolved
This pull request has merge conflicts that must be resolved before it can be merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK for @mdn/yari-content-fr
Thanks for this @queengooborg 🙇
This pull request has merge conflicts that must be resolved before it can be merged. |
Still awaiting approval from @mdn/yari-content-pt-br and @mdn/yari-content-ja! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for ja
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for pt-BR
, thank you very much!
This PR fixes all relative links to ensure that they start with a forward slash.