Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Markdownlint: enable "no-trailing-punctuation" rule #14243

Merged
merged 4 commits into from
Aug 2, 2023
Merged

Markdownlint: enable "no-trailing-punctuation" rule #14243

merged 4 commits into from
Aug 2, 2023

Conversation

queengooborg
Copy link
Collaborator

@queengooborg queengooborg commented Jul 14, 2023 •
edited
Loading

This PR enables the "no-trailing-punctuation" rule. This depends on all of the relevant formatting PRs to be merged first.

#14233
#14234
#14235
#14236
#14237
#14238
#14242

@queengooborg queengooborg requested a review from a team as a code owner July 14, 2023 18:43
@github-actions github-actions bot added the system Infrastructure and configuration for the project label Jul 14, 2023
@queengooborg queengooborg added the not ready Waiting on something else before this can be moved forward. label Jul 14, 2023
@queengooborg queengooborg changed the title Enable MD026 Markdownlint: enable "no-trailing-punctuation" rule Jul 20, 2023
@github-actions github-actions bot added the merge conflicts 🚧 This pull request has merge conflicts that must be resolved. label Jul 20, 2023
@github-actions
Copy link
Contributor

This pull request has merge conflicts that must be resolved before it can be merged.

@github-actions github-actions bot removed the merge conflicts 🚧 This pull request has merge conflicts that must be resolved. label Jul 20, 2023
@queengooborg queengooborg requested a review from a team as a code owner August 2, 2023 03:56
@queengooborg queengooborg requested review from swimjiy and removed request for a team August 2, 2023 03:56
@github-actions github-actions bot added the l10n-ko Issues related to Korean content. label Aug 2, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 2, 2023

Preview URLs

Flaws (5)

URL: /ko/docs/Web/API/Element/prepend
Title: Element: prepend() 메서드
Flaw count: 5

  • macros:
    • /ko/docs/Web/API/DOMException does not exist but fell back to /en-US/docs/Web/API/DOMException
    • /ko/docs/Web/JavaScript/Reference/Global_Objects/Symbol/unscopables does not exist but fell back to /en-US/docs/Web/JavaScript/Reference/Global_Objects/Symbol/unscopables
    • /ko/docs/Web/API/Element/append does not exist but fell back to /en-US/docs/Web/API/Element/append
    • /ko/docs/Web/API/Element/before does not exist but fell back to /en-US/docs/Web/API/Element/before
    • /ko/docs/Web/API/Element/insertAdjacentElement does not exist but fell back to /en-US/docs/Web/API/Element/insertAdjacentElement

@queengooborg queengooborg merged commit bbd1e5d into main Aug 2, 2023
11 of 12 checks passed
@queengooborg queengooborg deleted the lint/punctuation-in-header branch August 2, 2023 04:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swimjiy swimjiy Awaiting requested review from swimjiy swimjiy is a code owner automatically assigned from mdn/yari-content-ko

Assignees
No one assigned
Labels
l10n-ko Issues related to Korean content. not ready Waiting on something else before this can be moved forward. system Infrastructure and configuration for the project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@queengooborg