chore(prettierignore): remove code owner #14349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is no need for `@mdn/core-dev` to review changes to this file.
github-actions
bot
added
the
system
queengooborg
requested changes
Jul 18, 2023
There was a problem hiding this comment.
Removing the file from the CODEOWNERS sounds great to me!
However, would it be alright not to treat the file as a "system file"? Because we're working on formatting all the files with Prettier, it'd mean that all Prettier PRs will have a failing test, which may lead reviewers to want to hold off on taking a look. It looks far more pleasant to see a green check for such PRs! (Also, the upstream content doesn't treat .prettierignore as a system file!)
This reverts commit e25fdb6.
caugner
changed the title
queengooborg
approved these changes
Jul 18, 2023
|
Thank you very much! Let's get this merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes the code owners for
.prettierignore, and adds the file to thesystem-file-changescheck.Motivation
This means PRs changing the
.prettierignorefile no longer trigger a review request from@mdn/core-dev. However, the failingsystem-file-changescheck ensures reviewers notice the changes.Additional details
Related issues and pull requests