Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[zh-cn]: Update translation of String.localeCompare() #14351

Merged
merged 1 commit into from
Jul 19, 2023
Merged

[zh-cn]: Update translation of String.localeCompare() #14351

merged 1 commit into from
Jul 19, 2023

Conversation

JasonLamv-t
Copy link
Member

Description

Same as the title.

Motivation

Ditto.

Additional details

None.

Related issues and pull requests

#13975

@JasonLamv-t JasonLamv-t requested a review from a team as a code owner July 18, 2023 10:15
@JasonLamv-t JasonLamv-t requested review from yin1999 and removed request for a team July 18, 2023 10:15
@github-actions github-actions bot added the l10n-zh Issues related to Chinese content. label Jul 18, 2023
@JasonLamv-t JasonLamv-t mentioned this pull request Jul 18, 2023
Closed
55 tasks
@github-actions
Copy link
Contributor

Preview URLs

Flaws (1)

URL: /zh-CN/docs/Web/JavaScript/Reference/Global_Objects/String/localeCompare
Title: String.prototype.localeCompare()
Flaw count: 1

  • macros:
    • /zh-CN/docs/Web/JavaScript/Reference/Global_Objects/Intl/Collator/compare does not exist but fell back to /en-US/docs/Web/JavaScript/Reference/Global_Objects/Intl/Collator/compare

yin1999
yin1999 approved these changes Jul 19, 2023
View reviewed changes
Copy link
Member

@yin1999 yin1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks. I'm a bit busy those days, so sorry for the late /:

@yin1999 yin1999 merged commit ba779fd into mdn:main Jul 19, 2023
6 checks passed
@JasonLamv-t JasonLamv-t deleted the string-localeCompare branch July 19, 2023 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yin1999 yin1999 yin1999 approved these changes

Assignees
No one assigned
Labels
l10n-zh Issues related to Chinese content.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JasonLamv-t @yin1999