Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #14405 #14540

Merged
merged 5 commits into from
Jul 27, 2023
Merged

Fix #14405 #14540

merged 5 commits into from
Jul 27, 2023

Conversation

SphinxKnight
Copy link
Member

@SphinxKnight SphinxKnight commented Jul 23, 2023

Fixes #14405
Rework the whole page, include images' translation as well.

@SphinxKnight SphinxKnight requested a review from a team as a code owner July 23, 2023 09:40
@SphinxKnight SphinxKnight requested review from cw118 and removed request for a team July 23, 2023 09:40
@github-actions github-actions bot added the l10n-fr Issues related to French content. label Jul 23, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jul 23, 2023

Preview URLs

Flaws (8)

URL: /fr/docs/Web/HTTP/Content_negotiation
Title: La négociation de contenu
Flaw count: 8

  • broken_links:
    • Can use the English (en-US) link as a fallback
    • Can use the English (en-US) link as a fallback
    • Can use the English (en-US) link as a fallback
    • Can use the English (en-US) link as a fallback
    • Can use the English (en-US) link as a fallback
    • and 3 more flaws omitted
External URLs (4)

URL: /fr/docs/Web/HTTP/Content_negotiation
Title: La négociation de contenu

(comment last updated: 2023-07-27 21:38:35)

@SphinxKnight
Copy link
Member Author

I don't know where we should store original copies of diagrams (versions that can be edited instead of pngs,jpgs), so here we are: https://gist.github.com/SphinxKnight/5e78b8133db882fc34c479fae893b4ea

@cw118
Copy link
Member

cw118 commented Jul 25, 2023

I don't know where we should store original copies of diagrams (versions that can be edited instead of pngs,jpgs), so here we are: https://gist.github.com/SphinxKnight/5e78b8133db882fc34c479fae893b4ea

That is great 👍 Maybe we can insert an HTML comment above/below the image with the link of the gist corresponding to it, or create a document in this repository with links pointing to the gists all in one place?

Copy link
Member

@cw118 cw118 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🙏 I will merge this now, though I am open to (more) discussion on the placement/location of localized image files ^^

@cw118 cw118 merged commit e062663 into mdn:main Jul 27, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
l10n-fr Issues related to French content.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fr: Web/HTTP/Content_negotiation partially translated
2 participants