-
Notifications
You must be signed in to change notification settings - Fork 8.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #14405 #14540
Fix #14405 #14540
Conversation
Preview URLs Flaws (8)URL:
External URLs (4)URL:
(comment last updated: 2023-07-27 21:38:35) |
I don't know where we should store original copies of diagrams (versions that can be edited instead of pngs,jpgs), so here we are: https://gist.github.com/SphinxKnight/5e78b8133db882fc34c479fae893b4ea |
That is great 👍 Maybe we can insert an HTML comment above/below the image with the link of the gist corresponding to it, or create a document in this repository with links pointing to the gists all in one place? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🙏 I will merge this now, though I am open to (more) discussion on the placement/location of localized image files ^^
Fixes #14405
Rework the whole page, include images' translation as well.