Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

correct example code #14606

Merged
merged 4 commits into from
Jul 27, 2023
Merged

correct example code #14606

merged 4 commits into from
Jul 27, 2023

Conversation

KoutaTakeshi
Copy link
Contributor

replace double quotes to single quotes

Description

This part of guide want to show the single quotes and double quotes are universal, these two examples all use double quotes, I changed the first one to single quotes based on the english version.

Motivation

I am happy to help beginners avoid being confused about this.

@KoutaTakeshi
Correction
160a531 
replace double quote to single quote
@KoutaTakeshi KoutaTakeshi requested a review from a team as a code owner July 26, 2023 08:09
@KoutaTakeshi KoutaTakeshi requested review from irvin and removed request for a team July 26, 2023 08:09
@github-actions github-actions bot added the l10n-zh Issues related to Chinese content. label Jul 26, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jul 26, 2023 •
edited
Loading

Preview URLs

Flaws (34)

URL: /zh-CN/docs/Learn/HTML/Introduction_to_HTML/Getting_started
Title: 开始学习 HTML
Flaw count: 34

  • macros:
    • /zh-CN/docs/Learn/CSS/Building_blocks/Cascade_layers does not exist but fell back to /en-US/docs/Learn/CSS/Building_blocks/Cascade_layers
    • /zh-CN/docs/Learn/Performance/Multimedia does not exist but fell back to /en-US/docs/Learn/Performance/Multimedia
    • /zh-CN/docs/Learn/Performance/video does not exist but fell back to /en-US/docs/Learn/Performance/video
    • /zh-CN/docs/Learn/Performance/JavaScript does not exist but fell back to /en-US/docs/Learn/Performance/JavaScript
    • /zh-CN/docs/Learn/Performance/HTML does not exist but fell back to /en-US/docs/Learn/Performance/HTML
    • and 28 more flaws omitted
  • translation_differences:
    • Differences in the important macros (1 in common of 19 possible)

(comment last updated: 2023-07-27 04:06:17)

yin1999
yin1999 approved these changes Jul 27, 2023
View reviewed changes
Copy link
Member

@yin1999 yin1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@yin1999 yin1999 changed the title Update index.md correct example code Jul 27, 2023
@yin1999 yin1999 merged commit 1a52c95 into mdn:main Jul 27, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasonren0403 jasonren0403 jasonren0403 left review comments

@yin1999 yin1999 yin1999 approved these changes

@irvin irvin Awaiting requested review from irvin irvin is a code owner automatically assigned from mdn/yari-content-zh

Assignees
No one assigned
Labels
l10n-zh Issues related to Chinese content.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KoutaTakeshi @yin1999 @jasonren0403