Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add instruction about image #14628

Merged
merged 3 commits into from
Aug 4, 2023
Merged

feat: add instruction about image #14628

merged 3 commits into from
Aug 4, 2023

Conversation

striderkein
Copy link
Contributor

existing in the en but not in the ja

Instruction about image is existing in the English version but not in the Japanese version.
so I added it.

Description

add instruction about image in Japanese

Motivation

for the convenience of the developer"

Additional details

Related issues and pull requests

no related exists

@striderkein striderkein requested a review from a team as a code owner July 27, 2023 04:21
@striderkein striderkein requested review from mfuji09 and removed request for a team July 27, 2023 04:21
@github-actions github-actions bot added the l10n-ja Issues related to Japanese content. label Jul 27, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jul 27, 2023

Preview URLs

(comment last updated: 2023-08-04 07:55:42)

Copy link
Collaborator

@mfuji09 mfuji09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

警告の通り、 /en-us/ のリンク先は /ja/ のリンク先へ修正してください。
なお、日本語訳の記事におけるレビュアーは全員が日本人ですので、プルリクエストは日本語でどうぞ。

@striderkein
Copy link
Contributor Author

@mfuji09 コメントありがとうございます。ワーニングの 2 箇所を修正しましたのでご確認お願い致します

@striderkein striderkein requested a review from mfuji09 July 30, 2023 14:37
Copy link
Collaborator

@mfuji09 mfuji09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

警告の指摘事項が修正されていないので、修正方法を書いておきました。
再修正をお願いします。

files/ja/glossary/intrinsic_size/index.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@mfuji09 mfuji09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

修正ありがとうございました。OKです。

@mfuji09 mfuji09 merged commit 9e5a3e0 into mdn:main Aug 4, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
l10n-ja Issues related to Japanese content.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants