Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fr: Synchronize /Web/CSS/Shorthand_properties with upstream #14637

Merged
merged 5 commits into from
Jul 27, 2023

Conversation

queengooborg
Copy link
Collaborator

This PR replaces the tables in the Web/CSS/Shorthand_properties page of the French locale with unordered lists, just like it is in upstream. This helps us mitigate a Prettier-Markdownlint conflict due to Prettier unindenting the HTML elements, and synchronizes the page more with upstream.

Note: I did not add alt. text to the images because I don't speak French. Reviewers, please add alt. text to the images before merging this pull request.

@queengooborg queengooborg requested a review from a team as a code owner July 27, 2023 07:26
@queengooborg queengooborg requested review from SphinxKnight and removed request for a team July 27, 2023 07:26
@github-actions github-actions bot added the l10n-fr Issues related to French content. label Jul 27, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jul 27, 2023

Preview URLs

Flaws (2)

URL: /fr/docs/Web/CSS/Shorthand_properties
Title: Propriétés raccourcies
Flaw count: 2

  • macros:
    • wrong xref macro used (consider changing which macro you use)
  • broken_links:
    • Can use the English (en-US) link as a fallback

(comment last updated: 2023-07-27 21:20:58)

@SphinxKnight
Copy link
Member

@queengooborg if you don't mind, I'll push a commit to update the whole page :)

@queengooborg
Copy link
Collaborator Author

Much appreciated! Go for it, @SphinxKnight!

@SphinxKnight
Copy link
Member

SphinxKnight commented Jul 27, 2023

💅 DLs are underrated 💅 (as in, I went with what I think are slight improvements over the current English state)

@SphinxKnight SphinxKnight requested a review from cw118 July 27, 2023 08:42
@SphinxKnight
Copy link
Member

@cw118 whenever you have time for this, I would appreciate a second pair of eyes :) (no rush :))

@cw118 cw118 self-assigned this Jul 27, 2023
@queengooborg queengooborg changed the title fr: Replace tables in CSS shorthand properties page fr: Synchronize /Web/CSS/Shorthand_properties with upstream Jul 27, 2023
Copy link
Member

@cw118 cw118 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @queengooborg and @SphinxKnight, let's merge this one 🎉

@cw118 cw118 merged commit 0c7a4c8 into main Jul 27, 2023
9 checks passed
@cw118 cw118 deleted the fr/web/css/shorthand-properties branch July 27, 2023 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
l10n-fr Issues related to French content.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants