Remove unused assets #14664
Merged
Remove unused assets #14664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
queengooborg
requested review from
saionaro,
cos18,
jasonren0403 and
clovislima
and removed request for
a team
github-actions
bot
added
l10n-zh
|
Hi @queengooborg, should we always check assets under the folders that contains changed documents in PR test. |
yin1999
reviewed
Jul 28, 2023
There was a problem hiding this comment.
It seems that the firefox_logo.png under this folder is also not used anymore. Did filecheck tool misses this?
saionaro
approved these changes
Jul 30, 2023
yin1999
approved these changes
Jul 30, 2023
There was a problem hiding this comment.
I've removed one more unused image in zh-cn folder. Thank you @queengooborg
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes unused assets as found by
yarn filecheck.