zh-cn: Format /web/api using Prettier (part 1) #14673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
26
to
27
| abort(); | ||
| abort(reason); |
There was a problem hiding this comment.
a handy update
Suggested change
| abort(); | |
| abort(reason); | |
| AbortSignal.abort() | |
| AbortSignal.abort(reason) |
| @@ -23,8 +23,8 @@ return controller.signal; | |||
| ## 语法 | |||
|
|
|||
| ```js | |||
There was a problem hiding this comment.
Should have nolint
Suggested change
| ```js | |
| ```js-nolint |
| @@ -14,7 +14,7 @@ slug: Web/API/AbortSignal/throwIfAborted | |||
| ## 语法 | |||
|
|
|||
| ```js | |||
| throwIfAborted() | |||
| throwIfAborted(); | |||
There was a problem hiding this comment.
API part may contain a lot of code without nolint :(
Suggested change
| throwIfAborted(); | |
| throwIfAborted() |
| @@ -14,7 +14,7 @@ slug: Web/API/AbortSignal/throwIfAborted | |||
| ## 语法 | |||
|
|
|||
| ```js | |||
There was a problem hiding this comment.
Suggested change
| ```js | |
| ```js-nolint |
| @@ -17,7 +17,7 @@ original_slug: Web/API/AbortSignal/timeout | |||
| ## 语法 | |||
|
|
|||
| ```js | |||
| timeout(time) | |||
| timeout(time); | |||
There was a problem hiding this comment.
Suggested change
| timeout(time); | |
| AbortSignal.timeout(time) |
| @@ -17,7 +17,7 @@ original_slug: Web/API/AbortSignal/timeout | |||
| ## 语法 | |||
|
|
|||
| ```js | |||
There was a problem hiding this comment.
Suggested change
| ```js | |
| ```js-nolint |
jasonren0403
approved these changes
Jul 29, 2023
There was a problem hiding this comment.
Thank you @queengooborg , I've allowed myself to fix some occurences where 'nolint' should be added.
There was a problem hiding this comment.
It seems that we should not put anything in 5th param of EmbedLiveSample, or build would broke up.
I'm not sure if we should do a scan to batch remove 5th param in en-US content.
/cc @yin1999
There was a problem hiding this comment.
There does have a issue: mdn/content#25005
Preview URLs (100 pages)
Flaws (377)Note! 18 documents with no flaws that don't need to be listed. 🎉 URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR formats the
/web/apifolder of the Simplified Chinese locale using Prettier. This is the first part.