Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ko: Format /web/api using Prettier (part 1) #14706

Merged
merged 2 commits into from
Jul 31, 2023
Merged

ko: Format /web/api using Prettier (part 1) #14706

merged 2 commits into from
Jul 31, 2023

Conversation

queengooborg
Copy link
Collaborator

This PR formats the /web/api of the Korean locale using Prettier. This is the first part.

@queengooborg queengooborg requested a review from a team as a code owner July 29, 2023 08:37
@queengooborg queengooborg requested review from igy95 and removed request for a team July 29, 2023 08:37
@github-actions github-actions bot added l10n-ko Issues related to Korean content. merge conflicts 🚧 This pull request has merge conflicts that must be resolved. labels Jul 29, 2023
@github-actions
Copy link
Contributor

This pull request has merge conflicts that must be resolved before it can be merged.

@github-actions github-actions bot removed the merge conflicts 🚧 This pull request has merge conflicts that must be resolved. label Jul 30, 2023
@hochan222
Copy link
Member

hochan222 commented Jul 30, 2023 •
edited
Loading

@queengooborg Hello!

I'm planning to write a guide for Korean contributors to run the checker before contributing. (Which ones should I add?)

I wonder if you plan to provide guidance in the future with an English version or force git actions.

Oh We have a husky already. Great

@hochan222 hochan222 added the system Infrastructure and configuration for the project label Jul 30, 2023
@queengooborg
Copy link
Collaborator Author

Husky will help with linting locally, and then soon, I'll be porting over the workflows used in upstream content to enforce Prettier styling and the likes!

@queengooborg
Copy link
Collaborator Author

(Oh P.S., please feel free to ignore the build failure -- it's failing due to an existing issue unrelated to these changes!)

hochan222
hochan222 approved these changes Jul 31, 2023
View reviewed changes
Copy link
Member

@hochan222 hochan222 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@hochan222 hochan222 merged commit bb9dfcd into main Jul 31, 2023
9 of 10 checks passed
@hochan222 hochan222 deleted the ko/prettier/web/api/1 branch July 31, 2023 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hochan222 hochan222 hochan222 approved these changes

@igy95 igy95 Awaiting requested review from igy95 igy95 is a code owner automatically assigned from mdn/yari-content-ko

Assignees
No one assigned
Labels
l10n-ko Issues related to Korean content. system Infrastructure and configuration for the project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@queengooborg @hochan222