Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Data URLsの更新 #14753

Merged
merged 4 commits into from
Aug 4, 2023
Merged

Data URLsの更新 #14753

merged 4 commits into from
Aug 4, 2023

Conversation

muno92
Copy link
Contributor

@muno92 muno92 commented Jul 30, 2023

Description

Data URLsページに mdn/content@f9910a5 の変更を反映しました

Motivation

Additional details

Related issues and pull requests

Fixes mozilla-japan/translation#712

@muno92 muno92 requested a review from a team as a code owner July 30, 2023 08:10
@muno92 muno92 requested review from potappo and removed request for a team July 30, 2023 08:10
@github-actions github-actions bot added the l10n-ja Issues related to Japanese content. label Jul 30, 2023
@muno92 muno92 mentioned this pull request Jul 30, 2023
Closed
@github-actions
Copy link
Contributor

github-actions bot commented Aug 1, 2023 •
edited
Loading

Preview URLs

Flaws (9)

URL: /ja/docs/Web/HTTP/Basics_of_HTTP/Data_URLs
Title: データ URL
Flaw count: 9

  • macros:
    • Calling the Compat macro with any arguments is deprecated; instead use the 'browser-compat' front-matter key.
    • /ja/docs/Web/API/WindowBase64/atob redirects to /ja/docs/Web/API/atob
    • /ja/docs/Web/API/WindowBase64/btoa redirects to /ja/docs/Web/API/btoa
  • broken_links:
    • Can't resolve /ja/docs/Web/HTTP/Basics_of_HTTP/MIME_types/Complete_list_of_MIME_types
    • Can't resolve /ja/docs/Glossary/percent-encoding
    • Is currently http:// but can become https://
    • Can't resolve /ja/docs/Glossary/percent-encoding
    • Can't resolve /ja/docs/Web/CSS/uri
  • translation_differences:
    • Differences in the important macros (1 in common of 4 possible)
External URLs (1)

URL: /ja/docs/Web/HTTP/Basics_of_HTTP/Data_URLs
Title: データ URL

(comment last updated: 2023-08-03 12:18:04)

mfuji09
mfuji09 requested changes Aug 3, 2023
View reviewed changes
Copy link
Collaborator

@mfuji09 mfuji09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1件のコメントを確認してください。

files/ja/web/http/basics_of_http/data_urls/index.md Outdated Show resolved Hide resolved
@muno92
Copy link
Contributor Author

muno92 commented Aug 3, 2023

確認頂きありがとうございます。

変更提案取り込ませて頂きました。

mfuji09
mfuji09 approved these changes Aug 3, 2023
View reviewed changes
Copy link
Collaborator

@mfuji09 mfuji09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OKです。

@mfuji09 mfuji09 merged commit e17a930 into mdn:main Aug 4, 2023
8 checks passed
@mfuji09
Copy link
Collaborator

mfuji09 commented Aug 4, 2023

@muno92 さん
マージ完了しました。ありがとうございました。

@muno92
Copy link
Contributor Author

muno92 commented Aug 4, 2023

@mfuji09
こちらこそ、レビューありがとうございました！

@muno92 muno92 deleted the fix-712 branch August 4, 2023 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfuji09 mfuji09 mfuji09 approved these changes

@potappo potappo Awaiting requested review from potappo potappo is a code owner automatically assigned from mdn/yari-content-ja

Assignees
No one assigned
Labels
l10n-ja Issues related to Japanese content.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Data URLsの更新
2 participants
@muno92 @mfuji09