Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ko] translate learn/html/introduction_to_html/marking_up_a_letter/index.md #15070

Merged
merged 14 commits into from
Oct 10, 2023

Conversation

Chaerim0626
Copy link
Contributor

@Chaerim0626 Chaerim0626 commented Aug 12, 2023

Description

image
๐Ÿงฉ Marking up a letter ํ•œ๊ธ€ ๋ฒˆ์—ญ ํŽ˜์ด์ง€๊ฐ€ ์กด์žฌํ•˜์ง€ ์•Š์•„ index.md๋ฅผ ์ƒ์„ฑํ•˜๊ณ  ๋ฒˆ์—ญํ•˜์˜€์Šต๋‹ˆ๋‹ค. ์˜ˆ์‹œ ์ด๋ฏธ์ง€๋Š” ๋ ˆ๊ฑฐ์‹œ ๋ฌธ์„œ ์ž‘์—… ์ „์— ์—…๋กœ๋“œ ๋˜์–ด์žˆ๋˜ ์ด๋ฏธ์ง€ ํŒŒ์ผ์„ ์‚ฌ์šฉํ•˜์˜€์Šต๋‹ˆ๋‹ค.
MDN ๋งํฌ: https://developer.mozilla.org/ko/docs/Learn/HTML/Introduction_to_HTML/Marking_up_a_letter

Motivation

๐Ÿ’ก Marking up a letter ํŽ˜์ด์ง€ ๋ฒˆ์—ญ์— ๊ธฐ์—ฌํ•˜๊ณ  ์‹ถ์–ด์„œ ์ž‘์—…ํ•˜์˜€์Šต๋‹ˆ๋‹ค. html๊ณผ ๋”์šฑ ์นœ์ˆ™ํ•ด์งˆ ์ˆ˜ ์žˆ๋Š” ๊ณผ์ œ๋ฅผ ํ•œ๊ตญ์ธ๋ถ„๋“ค์ด ์ˆ˜ํ–‰ํ•ด ๋ณผ ์ˆ˜ ์žˆ๋Š” ๊ณ„๊ธฐ๊ฐ€ ๋˜์—ˆ์œผ๋ฉด ์ข‹๊ฒ ์Šต๋‹ˆ๋‹ค.

Additional details

Related issues and pull requests

@Chaerim0626 Chaerim0626 requested review from a team as code owners August 12, 2023 11:23
@Chaerim0626 Chaerim0626 requested review from sunhpark42 and removed request for a team August 12, 2023 11:23
@Chaerim0626 Chaerim0626 changed the title [ko] translate marking up a letter page [ko] translate Marking up a letter page Aug 12, 2023
@github-actions github-actions bot added l10n-ko Issues related to Korean content. system Infrastructure and configuration for the project labels Aug 12, 2023
@Chaerim0626 Chaerim0626 marked this pull request as draft August 12, 2023 11:24
@github-actions
Copy link
Contributor

github-actions bot commented Aug 12, 2023

Preview URLs

Flaws (98)

URL: /ko/docs/Learn/HTML/Introduction_to_HTML/Marking_up_a_letter
Title: ๊ณผ์ œ: ๋ฌธ์„œ ๋งˆํฌ์—…ํ•˜๊ธฐ
Flaw count: 98

  • macros:
    • /ko/docs/Learn/HTML/Introduction_to_HTML/Document_and_website_structure does not exist but fell back to /en-US/docs/Learn/HTML/Introduction_to_HTML/Document_and_website_structure
    • /ko/docs/Learn/HTML/Introduction_to_HTML/Debugging_HTML does not exist but fell back to /en-US/docs/Learn/HTML/Introduction_to_HTML/Debugging_HTML
    • /ko/docs/Learn/HTML/Multimedia_and_embedding/Video_and_audio_content does not exist but fell back to /en-US/docs/Learn/HTML/Multimedia_and_embedding/Video_and_audio_content
    • /ko/docs/Learn/HTML/Multimedia_and_embedding/Mozilla_splash_page does not exist but fell back to /en-US/docs/Learn/HTML/Multimedia_and_embedding/Mozilla_splash_page
    • /ko/docs/Learn/HTML/Tables/Advanced does not exist but fell back to /en-US/docs/Learn/HTML/Tables/Advanced
    • and 93 more flaws omitted
External URLs (5)

URL: /ko/docs/Learn/HTML/Introduction_to_HTML/Marking_up_a_letter
Title: ๊ณผ์ œ: ๋ฌธ์„œ ๋งˆํฌ์—…ํ•˜๊ธฐ

(comment last updated: 2023-10-10 07:53:33)

@yin1999
Copy link
Member

yin1999 commented Aug 12, 2023

Hi @Chaerim0626, the git-hook would automatically run prettier format. In general, we don't need to manually run prettier to format the file before commiting :)

@github-actions github-actions bot added the merge conflicts ๐Ÿšง This pull request has merge conflicts that must be resolved. label Aug 12, 2023
@github-actions
Copy link
Contributor

This pull request has merge conflicts that must be resolved before it can be merged.

@github-actions github-actions bot removed system Infrastructure and configuration for the project merge conflicts ๐Ÿšง This pull request has merge conflicts that must be resolved. labels Aug 13, 2023
@Chaerim0626 Chaerim0626 marked this pull request as ready for review August 13, 2023 13:01
@Chaerim0626
Copy link
Contributor Author

Hi @Chaerim0626, the git-hook would automatically run prettier format. In general, we don't need to manually run prettier to format the file before commiting :)

Thank you very much for your explanation ๐Ÿ˜€

@Chaerim0626 Chaerim0626 changed the title [ko] translate Marking up a letter page [ko] translate /learn/html/introduction_to_html/marking_up_a_letter/index.md Aug 13, 2023
@Chaerim0626 Chaerim0626 changed the title [ko] translate /learn/html/introduction_to_html/marking_up_a_letter/index.md [ko] translate learn/html/introduction_to_html/marking_up_a_letter/index.md Aug 13, 2023
@Chaerim0626 Chaerim0626 changed the title [ko] translate learn/html/introduction_to_html/marking_up_a_letter/index.md [ko] translate learn/html/introduction_to_html/marking_up_a_letter/index.md Aug 13, 2023
@Chaerim0626 Chaerim0626 changed the title [ko] translate learn/html/introduction_to_html/marking_up_a_letter/index.md [ko] translate learn/html/introduction_to_html/marking_up_a_letter/index.md Aug 13, 2023
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Chaerim0626. If you just copied this image from en-US without any modification. You could just remove it.

As yari could now automatically copy the images under the corresponding English folder to the localization folder.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I deleted the image file ๐Ÿ˜Š

@yin1999 yin1999 removed the request for review from a team August 13, 2023 14:35
files/ko/learn/javascript/first_steps/variables/index.md Outdated Show resolved Hide resolved
files/ko/learn/javascript/first_steps/variables/index.md Outdated Show resolved Hide resolved
files/ko/learn/javascript/first_steps/variables/index.md Outdated Show resolved Hide resolved
files/ko/learn/javascript/first_steps/variables/index.md Outdated Show resolved Hide resolved
files/ko/learn/javascript/first_steps/variables/index.md Outdated Show resolved Hide resolved
files/ko/learn/javascript/first_steps/variables/index.md Outdated Show resolved Hide resolved
files/ko/learn/javascript/first_steps/variables/index.md Outdated Show resolved Hide resolved
files/ko/learn/javascript/first_steps/variables/index.md Outdated Show resolved Hide resolved
files/ko/learn/javascript/first_steps/variables/index.md Outdated Show resolved Hide resolved
files/ko/learn/javascript/first_steps/variables/index.md Outdated Show resolved Hide resolved
@Chaerim0626 Chaerim0626 changed the title [ko] translate learn/html/introduction_to_html/marking_up_a_letter/index.md [ko] translate learn/html/introduction_to_html/marking_up_a_letter/index.md Aug 21, 2023
@Chaerim0626
Copy link
Contributor Author

์ด PR์— ์ž‘์—…ํ•˜๋˜ ๋‹ค๋ฅธ JavaScript MDN ๋ฒˆ์—ญํŒŒ์ผ์ด ๊ฐ™์ด ์˜ฌ๋ผ๊ฐ€์„œ ์ง€์šฐ๋Š” ์ž‘์—…์„ ํ•˜์˜€์Šต๋‹ˆ๋‹ค. ํ˜ผ๋ž€์„ ๋ผ์ณ์„œ ์ฃ„์†กํ•ฉ๋‹ˆ๋‹ค..!

@hochan222
Copy link
Member

@sunhpark42 ๋‹˜, ์•ˆ๋…•ํ•˜์„ธ์š”. ์ผ์ฃผ์ผ๋‚ด๋กœ ํ˜„์žฌ PR ๋ฆฌ๋ทฐ ๊ณ„ํš์ด ์žˆ์œผ์‹œ๋ฉด ๋ฆฌ๋ทฐ ์ผ์ • ์ปค๋ฉ˜ํŠธ๋กœ ๋ง์”€ ๋ถ€ํƒ๋“œ๋ฆฝ๋‹ˆ๋‹ค. ๋ฆฌ๋ทฐ ๋“œ๋ฆฌ๊ธฐ ์–ด๋ ค์šธ๋“ฏํ•˜๋ฉด ๋ง์”€ํ•ด์ฃผ์„ธ์š”~!

๋ชจ๋‘ ์ข‹์€ ์ฃผ๋ง ๋ณด๋‚ด์„ธ์š” :)

Copy link
Member

@hochan222 hochan222 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Chaerim0626 ๋‹˜ ์•ˆ๋…•ํ•˜์„ธ์š”.

๊ธฐ์—ฌํ•ด์ฃผ์…”์„œ ๊ฐ์‚ฌํ•ฉ๋‹ˆ๋‹ค. ๋ฆฌ๋ทฐ ๋‚ด์šฉ ํ•˜๊ธฐ์— ๋‚จ๊ฒจ๋‘์—ˆ์Šต๋‹ˆ๋‹ค. ๋‹ค๋งŒ, ๊ฒฝ๋ฏธํ•˜์—ฌ ๋ฐ˜์˜ ํ›„ ๋ณ‘ํ•ฉํ•˜๊ฒ ์Šต๋‹ˆ๋‹ค.

๊ธฐ์—ฌ ๋‚ด์šฉ mdn ์ปค๋ฎค๋‹ˆํ‹ฐ์— ํฐ ๋„์›€์ด ๋˜์—ˆ์Šต๋‹ˆ๋‹ค.

๋ฆฌ๋ทฐ๊ฐ€ ์ง€์—ฐ๋˜์–ด์„œ ๋‹ค์‹œ ํ•œ๋ฒˆ ์ •๋ง ์ฃ„์†กํ•ฉ๋‹ˆ๋‹ค. ์ข‹์€ ํ•˜๋ฃจ ๋ณด๋‚ด์„ธ์š” :)

@hochan222 hochan222 merged commit 78cfc96 into mdn:main Oct 10, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
l10n-ko Issues related to Korean content.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants