Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(zh): remove localhost links #15138

Merged
merged 4 commits into from
Aug 16, 2023
Merged

fix(zh): remove localhost links #15138

merged 4 commits into from
Aug 16, 2023

Conversation

yin1999
Copy link
Member

@yin1999 yin1999 commented Aug 16, 2023

Description

remove localhost links

Run yarn markdownlint-cli2 "files/zh-cn/**/*.md" and yarn markdownlint-cli2 "files/zh-tw/**/*.md" locally to test this.

@yin1999 yin1999 requested a review from a team as a code owner August 16, 2023 03:26
@yin1999 yin1999 requested review from t7yang and removed request for a team August 16, 2023 03:26
@github-actions github-actions bot added the l10n-zh Issues related to Chinese content. label Aug 16, 2023
@yin1999
Copy link
Member Author

yin1999 commented Aug 16, 2023

Hi @queengooborg, the changes we made in #15106 would not trigger markdown-lint for all files.

Could you help with this :)

@github-actions
Copy link
Contributor

github-actions bot commented Aug 16, 2023

Preview URLs (6 pages)
Flaws (393)

Note! 1 document with no flaws that don't need to be listed. 🎉

URL: /zh-CN/docs/Learn/Server-side/Express_Nodejs/routes
Title: Express 教程 4:路由和控制器
Flaw count: 35

  • macros:
    • /zh-CN/docs/Learn/CSS/Building_blocks/Cascade_layers does not exist but fell back to /en-US/docs/Learn/CSS/Building_blocks/Cascade_layers
    • /zh-CN/docs/Learn/Performance/Multimedia does not exist but fell back to /en-US/docs/Learn/Performance/Multimedia
    • /zh-CN/docs/Learn/Performance/video does not exist but fell back to /en-US/docs/Learn/Performance/video
    • /zh-CN/docs/Learn/Performance/JavaScript does not exist but fell back to /en-US/docs/Learn/Performance/JavaScript
    • /zh-CN/docs/Learn/Performance/HTML does not exist but fell back to /en-US/docs/Learn/Performance/HTML
    • and 28 more flaws omitted
  • broken_links:
    • Anchor not lowercase
    • Can't resolve /zh-CN/docs/learn/Server-side/Express_Nodejs/forms

URL: /zh-CN/docs/Learn/Server-side/Express_Nodejs/skeleton_website
Title: Express 教程 2:创建站点框架
Flaw count: 35

  • macros:
    • /zh-CN/docs/Learn/CSS/Building_blocks/Cascade_layers does not exist but fell back to /en-US/docs/Learn/CSS/Building_blocks/Cascade_layers
    • /zh-CN/docs/Learn/Performance/Multimedia does not exist but fell back to /en-US/docs/Learn/Performance/Multimedia
    • /zh-CN/docs/Learn/Performance/video does not exist but fell back to /en-US/docs/Learn/Performance/video
    • /zh-CN/docs/Learn/Performance/JavaScript does not exist but fell back to /en-US/docs/Learn/Performance/JavaScript
    • /zh-CN/docs/Learn/Performance/HTML does not exist but fell back to /en-US/docs/Learn/Performance/HTML
    • and 28 more flaws omitted
  • broken_links:
    • Is currently http:// but can become https://
    • Is currently http:// but can become https://

URL: /zh-CN/docs/Learn/Tools_and_testing/Cross_browser_testing/Your_own_automation_environment
Title: 建立自己的自动化测试环境
Flaw count: 34

  • macros:
    • /zh-CN/docs/Learn/CSS/Building_blocks/Cascade_layers does not exist but fell back to /en-US/docs/Learn/CSS/Building_blocks/Cascade_layers
    • /zh-CN/docs/Learn/Performance/Multimedia does not exist but fell back to /en-US/docs/Learn/Performance/Multimedia
    • /zh-CN/docs/Learn/Performance/video does not exist but fell back to /en-US/docs/Learn/Performance/video
    • /zh-CN/docs/Learn/Performance/JavaScript does not exist but fell back to /en-US/docs/Learn/Performance/JavaScript
    • /zh-CN/docs/Learn/Performance/HTML does not exist but fell back to /en-US/docs/Learn/Performance/HTML
    • and 28 more flaws omitted
  • broken_links:
    • Anchor not lowercase

URL: /zh-TW/docs/Learn/Server-side/Express_Nodejs/routes
Title: Express 教學 4: 路由與控制器
Flaw count: 145

  • macros:
    • /zh-TW/docs/Learn/HTML/Introduction_to_HTML/Advanced_text_formatting does not exist but fell back to /en-US/docs/Learn/HTML/Introduction_to_HTML/Advanced_text_formatting
    • /zh-TW/docs/Learn/HTML/Introduction_to_HTML/Debugging_HTML does not exist but fell back to /en-US/docs/Learn/HTML/Introduction_to_HTML/Debugging_HTML
    • /zh-TW/docs/Learn/HTML/Introduction_to_HTML/Marking_up_a_letter does not exist but fell back to /en-US/docs/Learn/HTML/Introduction_to_HTML/Marking_up_a_letter
    • /zh-TW/docs/Learn/HTML/Introduction_to_HTML/Structuring_a_page_of_content does not exist but fell back to /en-US/docs/Learn/HTML/Introduction_to_HTML/Structuring_a_page_of_content
    • /zh-TW/docs/Learn/HTML/Multimedia_and_embedding/Video_and_audio_content does not exist but fell back to /en-US/docs/Learn/HTML/Multimedia_and_embedding/Video_and_audio_content
    • and 137 more flaws omitted
  • broken_links:
    • Anchor not lowercase
    • Anchor not lowercase
    • Can't resolve /zh-CN/docs/Web/JavaScript/Guide/Regular_Expressions

URL: /zh-TW/docs/Learn/Server-side/Express_Nodejs/skeleton_website
Title: Express 教學 2: 創建一個骨架網站
Flaw count: 144

  • macros:
    • /zh-TW/docs/Learn/HTML/Introduction_to_HTML/Advanced_text_formatting does not exist but fell back to /en-US/docs/Learn/HTML/Introduction_to_HTML/Advanced_text_formatting
    • /zh-TW/docs/Learn/HTML/Introduction_to_HTML/Debugging_HTML does not exist but fell back to /en-US/docs/Learn/HTML/Introduction_to_HTML/Debugging_HTML
    • /zh-TW/docs/Learn/HTML/Introduction_to_HTML/Marking_up_a_letter does not exist but fell back to /en-US/docs/Learn/HTML/Introduction_to_HTML/Marking_up_a_letter
    • /zh-TW/docs/Learn/HTML/Introduction_to_HTML/Structuring_a_page_of_content does not exist but fell back to /en-US/docs/Learn/HTML/Introduction_to_HTML/Structuring_a_page_of_content
    • /zh-TW/docs/Learn/HTML/Multimedia_and_embedding/Video_and_audio_content does not exist but fell back to /en-US/docs/Learn/HTML/Multimedia_and_embedding/Video_and_audio_content
    • and 137 more flaws omitted
  • broken_links:
    • Is currently http:// but can become https://
    • Is currently http:// but can become https://
External URLs (7)

URL: /zh-CN/docs/Learn/Server-side/Express_Nodejs/routes
Title: Express 教程 4:路由和控制器


URL: /zh-CN/docs/Learn/Server-side/Express_Nodejs/skeleton_website
Title: Express 教程 2:创建站点框架


URL: /zh-TW/docs/Learn/Server-side/Express_Nodejs/routes
Title: Express 教學 4: 路由與控制器

(comment last updated: 2023-08-16 15:40:30)

@yin1999 yin1999 changed the title fix(zh-cn): remove localhost links fix(zh): remove localhost links Aug 16, 2023
@queengooborg
Copy link
Collaborator

Hi @queengooborg, the changes we made in #15106 would not trigger markdown-lint for all files.

Is #15141 what you're looking for?

Copy link
Contributor

@jasonren0403 jasonren0403 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jasonren0403 jasonren0403 merged commit 7c69b89 into main Aug 16, 2023
10 checks passed
@jasonren0403 jasonren0403 deleted the remove-links branch August 16, 2023 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
l10n-zh Issues related to Chinese content.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants