Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(ci): bump prettier to v3.0.2 and re-format documents #15227

Merged
merged 2 commits into from
Aug 19, 2023
Merged

chore(ci): bump prettier to v3.0.2 and re-format documents #15227

merged 2 commits into from
Aug 19, 2023

Conversation

yin1999
Copy link
Member

@yin1999 yin1999 commented Aug 19, 2023

Description

bump prettier to v3.0.2 and re-format documents

Motivation

Breaking changes in v3.0.3.

Related issues and pull requests

Follow: mdn/content#28648.

@yin1999 yin1999 requested review from a team as code owners August 19, 2023 01:24
@yin1999 yin1999 requested review from Graywolf9, lex111, SphinxKnight and jasonren0403 and removed request for a team August 19, 2023 01:24
@github-actions github-actions bot added l10n-fr Issues related to French content. l10n-zh Issues related to Chinese content. l10n-es Issues related to Spanish content. l10n-ru Issues related to Russian content. system Infrastructure and configuration for the project labels Aug 19, 2023
github-actions[bot]
github-actions bot reviewed Aug 19, 2023
View reviewed changes
files/es/web/api/screen_capture_api/index.md
Comment on lines +19 to +20
captureStream =
await navigator.mediaDevices.getDisplayMedia(displayMediaOptions);

This comment was marked as outdated.

Sign in to view

files/es/web/api/screen_capture_api/using_screen_capture/index.md
Comment on lines +25 to +26
captureStream =
await navigator.mediaDevices.getDisplayMedia(displayMediaOptions);

This comment was marked as outdated.

Sign in to view

files/es/web/api/screen_capture_api/using_screen_capture/index.md
Comment on lines +215 to +216
videoElem.srcObject =
await navigator.mediaDevices.getDisplayMedia(displayMediaOptions);

This comment was marked as outdated.

Sign in to view

files/fr/web/api/screen_capture_api/index.md
Comment on lines +17 to +18
captureStream =
await navigator.mediaDevices.getDisplayMedia(displayMediaOptions);

This comment was marked as outdated.

Sign in to view

files/ru/web/api/screen_capture_api/using_screen_capture/index.md
Comment on lines +23 to +24
captureStream =
await navigator.mediaDevices.getDisplayMedia(displayMediaOptions);

This comment was marked as outdated.

Sign in to view

files/ru/web/api/screen_capture_api/using_screen_capture/index.md
Comment on lines +235 to +236
videoElem.srcObject =
await navigator.mediaDevices.getDisplayMedia(displayMediaOptions);

This comment was marked as outdated.

Sign in to view

files/zh-cn/web/api/mediadevices/getdisplaymedia/index.md
Comment on lines +57 to +58
captureStream =
await navigator.mediaDevices.getDisplayMedia(displayMediaOptions);

This comment was marked as outdated.

Sign in to view

files/zh-cn/web/api/screen_capture_api/index.md
Comment on lines +17 to +18
captureStream =
await navigator.mediaDevices.getDisplayMedia(displayMediaOptions);

This comment was marked as outdated.

Sign in to view

@github-actions
Copy link
Contributor

Preview URLs (6 pages)
Flaws (143)

URL: /zh-CN/docs/Web/API/MediaDevices/getDisplayMedia
Title: MediaDevices.getDisplayMedia()
Flaw count: 6

  • macros:
    • /zh-CN/docs/Web/API/MediaStreamConstraints does not exist but fell back to /en-US/docs/Web/API/MediaDevices/getUserMedia
    • /zh-CN/docs/Web/API/MediaStreamConstraints does not exist but fell back to /en-US/docs/Web/API/MediaDevices/getUserMedia
    • /zh-CN/docs/Web/JavaScript/Reference/await does not exist
  • broken_links:
    • Can use the English (en-US) link as a fallback
    • Can use the English (en-US) link as a fallback
    • Can't resolve /zh-CN/docs/Web/API/Media_Streams_API

URL: /zh-CN/docs/Web/API/Screen_Capture_API
Title: 屏幕捕捉 API
Flaw count: 16

  • macros:
    • /zh-CN/docs/Web/API/MediaTrackConstraints/cursor does not exist but fell back to /en-US/docs/Web/API/MediaTrackConstraints
    • /zh-CN/docs/Web/API/ConstrainDOMString does not exist but fell back to /en-US/docs/Web/API/MediaTrackConstraints
    • /zh-CN/docs/Web/API/MediaTrackConstraints/displaySurface does not exist but fell back to /en-US/docs/Web/API/MediaTrackConstraints/displaySurface
    • /zh-CN/docs/Web/API/ConstrainDOMString does not exist but fell back to /en-US/docs/Web/API/MediaTrackConstraints
    • /zh-CN/docs/Web/API/MediaTrackConstraints/logicalSurface does not exist but fell back to /en-US/docs/Web/API/MediaTrackConstraints/logicalSurface
    • and 9 more flaws omitted
  • broken_links:
    • Can't resolve /zh-CN/docs/Web/HTTP/Feature_Policy/Using_Feature_Policy
    • Can use the English (en-US) link as a fallback

URL: /es/docs/Web/API/Screen_Capture_API
Title: API de captura de pantalla
Flaw count: 29

  • macros:
    • /es/docs/Web/API/MediaDevices/getDisplayMedia does not exist but fell back to /en-US/docs/Web/API/MediaDevices/getDisplayMedia
    • /es/docs/Web/API/MediaStream does not exist but fell back to /en-US/docs/Web/API/MediaStream
    • /es/docs/Web/API/MediaStream does not exist but fell back to /en-US/docs/Web/API/MediaStream
    • /es/docs/Web/API/CaptureController does not exist but fell back to /en-US/docs/Web/API/CaptureController
    • /es/docs/Web/API/MediaDevices/getDisplayMedia does not exist but fell back to /en-US/docs/Web/API/MediaDevices/getDisplayMedia
    • and 21 more flaws omitted
  • broken_links:
    • Can use the English (en-US) link as a fallback
    • Can use the English (en-US) link as a fallback
    • Can use the English (en-US) link as a fallback

URL: /es/docs/Web/API/Screen_Capture_API/Using_Screen_Capture
Title: Uso de la API de captura de pantalla
Flaw count: 38

  • macros:
    • /es/docs/Web/API/MediaDevices/getDisplayMedia does not exist but fell back to /en-US/docs/Web/API/MediaDevices/getDisplayMedia
    • /es/docs/Web/API/MediaStream does not exist but fell back to /en-US/docs/Web/API/MediaStream
    • /es/docs/Web/API/MediaDevices/getDisplayMedia does not exist but fell back to /en-US/docs/Web/API/MediaDevices/getDisplayMedia
    • /es/docs/Glossary/user_agent does not exist but fell back to /en-US/docs/Glossary/User_agent
    • /es/docs/Web/API/MediaStream does not exist but fell back to /en-US/docs/Web/API/MediaStream
    • and 29 more flaws omitted
  • broken_links:
    • Can use the English (en-US) link as a fallback
    • Can use the English (en-US) link as a fallback
    • Can use the English (en-US) link as a fallback
  • translation_differences:
    • Differences in the important macros (2 in common of 4 possible)

URL: /ru/docs/Web/API/Screen_Capture_API/Using_Screen_Capture
Title: Использование интерфейса Screen Capture API
Flaw count: 33

  • macros:
    • /ru/docs/Web/API/MediaDevices/getDisplayMedia does not exist but fell back to /en-US/docs/Web/API/MediaDevices/getDisplayMedia
    • /ru/docs/Web/API/MediaDevices/getDisplayMedia does not exist but fell back to /en-US/docs/Web/API/MediaDevices/getDisplayMedia
    • /ru/docs/Web/API/DisplayMediaStreamConstraints does not exist but fell back to /en-US/docs/Web/API/MediaDevices/getDisplayMedia
    • /ru/docs/Web/API/MediaTrackSupportedConstraints does not exist but fell back to /en-US/docs/Web/API/MediaTrackSupportedConstraints
    • /ru/docs/Web/API/MediaTrackSettings does not exist but fell back to /en-US/docs/Web/API/MediaTrackSettings
    • and 19 more flaws omitted
  • broken_links:
    • Can use the English (en-US) link as a fallback
    • Can use the English (en-US) link as a fallback
    • Can use the English (en-US) link as a fallback
    • Can't resolve /ru/docs/Web/HTTP/Feature_Policy
    • Can use the English (en-US) link as a fallback
    • and 3 more flaws omitted
  • translation_differences:
    • Differences in the important macros (1 in common of 4 possible)

URL: /fr/docs/Web/API/Screen_Capture_API
Title: Screen Capture API
Flaw count: 21

  • macros:
    • /fr/docs/Web/API/MediaDevices/getDisplayMedia does not exist but fell back to /en-US/docs/Web/API/MediaDevices/getDisplayMedia
    • /fr/docs/Web/API/MediaDevices/getDisplayMedia does not exist but fell back to /en-US/docs/Web/API/MediaDevices/getDisplayMedia
    • /fr/docs/Web/API/MediaTrackConstraints/cursor does not exist but fell back to /en-US/docs/Web/API/MediaTrackConstraints
    • /fr/docs/Web/API/ConstrainDOMString does not exist but fell back to /en-US/docs/Web/API/MediaTrackConstraints
    • /fr/docs/Web/API/MediaTrackConstraints/displaySurface does not exist but fell back to /en-US/docs/Web/API/MediaTrackConstraints/displaySurface
    • and 12 more flaws omitted
  • broken_links:
    • Can use the English (en-US) link as a fallback
    • Can't resolve /fr/docs/Web/HTTP/Headers/Feature-Policy
    • Can't resolve /fr/docs/Web/HTTP/Feature_Policy/Using_Feature_Policy
    • Can use the English (en-US) link as a fallback

jasonren0403
jasonren0403 approved these changes Aug 19, 2023
View reviewed changes
Copy link
Contributor

@jasonren0403 jasonren0403 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for all(they are just code block changes) 👍

BTW, I see reviewdog still suggesting old-version corrections, will they be resolved after prettier update?

@yin1999
Copy link
Member Author

yin1999 commented Aug 19, 2023

BTW, I see reviewdog still suggesting old-version corrections, will they be resolved after prettier update?

Yes. The "Lint and review content files" workflow would use the "main" version of "package.json".

queengooborg
queengooborg approved these changes Aug 19, 2023
View reviewed changes
Copy link
Collaborator

@queengooborg queengooborg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, all changes look good!

@queengooborg queengooborg merged commit 004075e into mdn:main Aug 19, 2023
8 of 10 checks passed
@yin1999 yin1999 deleted the bump-prettier branch August 19, 2023 05:03
Graywolf9
Graywolf9 reviewed Aug 21, 2023
View reviewed changes
Copy link
Contributor

@Graywolf9 Graywolf9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@Graywolf9 Graywolf9 Graywolf9 left review comments

@jasonren0403 jasonren0403 jasonren0403 approved these changes

@queengooborg queengooborg queengooborg approved these changes

@lex111 lex111 Awaiting requested review from lex111 lex111 is a code owner automatically assigned from mdn/yari-content-ru

@SphinxKnight SphinxKnight Awaiting requested review from SphinxKnight SphinxKnight is a code owner automatically assigned from mdn/yari-content-fr

Assignees
No one assigned
Labels
l10n-es Issues related to Spanish content. l10n-fr Issues related to French content. l10n-ru Issues related to Russian content. l10n-zh Issues related to Chinese content. system Infrastructure and configuration for the project
Projects
l10n-fr
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yin1999 @queengooborg @Graywolf9 @jasonren0403