Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[zh-cn]: Update translation of String.blink() #15303

Merged
merged 3 commits into from
Aug 21, 2023
Merged

[zh-cn]: Update translation of String.blink() #15303

merged 3 commits into from
Aug 21, 2023

Conversation

JasonLamv-t
Copy link
Member

Description

Same as the title.

Motivation

Ditto.

Additional details

None.

Related issues and pull requests

#13975

@JasonLamv-t JasonLamv-t requested a review from a team as a code owner August 21, 2023 02:46
@JasonLamv-t JasonLamv-t requested review from yin1999 and removed request for a team August 21, 2023 02:46
@github-actions github-actions bot added the l10n-zh Issues related to Chinese content. label Aug 21, 2023
@JasonLamv-t JasonLamv-t mentioned this pull request Aug 21, 2023
Closed
55 tasks
@github-actions
Copy link
Contributor

github-actions bot commented Aug 21, 2023 •
edited
Loading

Preview URLs

Flaws (1)

URL: /zh-CN/docs/Web/JavaScript/Reference/Global_Objects/String/blink
Title: String.prototype.blink()
Flaw count: 1

  • macros:
    • /zh-CN/docs/Web/JavaScript/Reference/Global_Objects/String/italics does not exist but fell back to /en-US/docs/Web/JavaScript/Reference/Global_Objects/String/italics
External URLs (1)

URL: /zh-CN/docs/Web/JavaScript/Reference/Global_Objects/String/blink
Title: String.prototype.blink()

(comment last updated: 2023-08-21 06:40:11)

yin1999
yin1999 reviewed Aug 21, 2023
View reviewed changes
Copy link
Member

@yin1999 yin1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one nit. Could we add "值" here. As this is an instance method.

files/zh-cn/web/javascript/reference/global_objects/string/blink/index.md Outdated Show resolved Hide resolved
yin1999
yin1999 approved these changes Aug 21, 2023
View reviewed changes
Copy link
Member

@yin1999 yin1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@yin1999 yin1999 merged commit 68c6507 into mdn:main Aug 21, 2023
7 checks passed
@JasonLamv-t JasonLamv-t deleted the string-blink branch August 21, 2023 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yin1999 yin1999 yin1999 approved these changes

Assignees
No one assigned
Labels
l10n-zh Issues related to Chinese content.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JasonLamv-t @yin1999