Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix WebGL example links #16765

Merged
merged 4 commits into from
Nov 6, 2023
Merged

Fix WebGL example links #16765

merged 4 commits into from
Nov 6, 2023

Conversation

mikecat
Copy link
Contributor

@mikecat mikecat commented Oct 30, 2023

Description

Replaced broken links using TextSS.net without manual verification:

  • Replaced https://github.com/mdn/webgl-examples/ to https://github.com/mdn/dom-examples/tree/main/webgl-examples/
  • Replaced EmbedGHLiveSample('webgl-examples/ to EmbedGHLiveSample('dom-examples/webgl-examples/
  • Replaced http://mdn.github.io/webgl-examples/ to https://mdn.github.io/dom-examples/webgl-examples/

Motivation

Additional details

Related issues and pull requests

@mikecat mikecat requested review from a team as code owners October 30, 2023 10:50
@mikecat mikecat requested review from Jalkhov, myshov, potappo, cw118, jasonren0403 and josielrocha and removed request for a team October 30, 2023 10:50
@github-actions github-actions bot added l10n-ja Issues related to Japanese content. l10n-fr Issues related to French content. l10n-zh Issues related to Chinese content. l10n-es Issues related to Spanish content. l10n-ru Issues related to Russian content. l10n-pt-br Issues related to Brazilian Portuguese labels Oct 30, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 30, 2023 •
edited
Loading

Preview URLs (27 pages)
Flaws (144)

Note! 10 documents with no flaws that don't need to be listed. 🎉

URL: /ja/docs/Web/Guide/Audio_and_video_manipulation
Title: 音声と動画の加工
Flaw count: 17

  • macros:
    • /ja/docs/Web/API/BiquadFilterNode does not exist but fell back to /en-US/docs/Web/API/BiquadFilterNode
    • /ja/docs/Web/API/BiquadFilterNode does not exist but fell back to /en-US/docs/Web/API/BiquadFilterNode
    • /ja/docs/web/apps/fundamentals (url: /ja/docs/Web/Apps/Fundamentals) does not exist
  • broken_links:
    • Can't resolve /ja/docs/Web/WebGL
    • Can use the English (en-US) link as a fallback
    • Can't resolve /ja/docs/Web/WebGL
    • Can use the English (en-US) link as a fallback
    • Is currently http:// but can become https://
    • and 8 more flaws omitted
  • translation_differences:
    • Differences in the important macros (2 in common of 6 possible)

URL: /ja/docs/Web/API/WebGL_API/Tutorial/Using_textures_in_WebGL
Title: WebGL でのテクスチャの使用
Flaw count: 5

  • broken_links:
    • Can use the English (en-US) link as a fallback
    • Can't resolve /ja/docs/Web/WebGL/Using_textures_in_WebGL#Non_power-of-two_textures
    • Can't resolve /ja/docs/HTTP_access_control
    • Is currently http:// but can become https://
    • Is currently http:// but can become https://

URL: /ja/docs/Web/API/WebXR_Device_API/Movement_and_motion
Title: 移動、向き、モーション: WebXR の例
Flaw count: 26

  • macros:
    • /ja/docs/Web/API/XRWebGLLayer does not exist but fell back to /en-US/docs/Web/API/XRWebGLLayer
    • /ja/docs/Web/API/XRWebGLLayer/viewport does not exist
    • /ja/docs/Web/API/XRSession does not exist but fell back to /en-US/docs/Web/API/XRSession
    • /ja/docs/Web/API/XRSystem/requestSession does not exist but fell back to /en-US/docs/Web/API/XRSystem/requestSession
    • /ja/docs/Web/API/XRSession/end does not exist but fell back to /en-US/docs/Web/API/XRSession/end
    • and 18 more flaws omitted
  • broken_links:
    • Is currently http:// but can become https://
    • Can use the English (en-US) link as a fallback
    • Anchor not lowercase

URL: /fr/docs/Web/Guide/Audio_and_video_manipulation
Title: Manipulation Audio et Vidéo
Flaw count: 15

  • macros:
    • /fr/docs/Web/API/MediaElementAudioSourceNode does not exist but fell back to /en-US/docs/Web/API/MediaElementAudioSourceNode
    • /fr/docs/Web/API/ConvolverNode does not exist but fell back to /en-US/docs/Web/API/ConvolverNode
    • /fr/docs/Web/API/ConvolverNode does not exist but fell back to /en-US/docs/Web/API/ConvolverNode
    • /fr/docs/Web/API/PannerNode does not exist but fell back to /en-US/docs/Web/API/PannerNode
  • broken_links:
    • Can't resolve /fr/docs/Web/WebGL
    • Can't resolve /fr/docs/NavigatorUserMedia.getUserMedia
    • Can't resolve /fr/docs/Web/HTTP/Access_control_CORS
    • Can't resolve /fr/docs/HTML/Manipulating_video_using_canvas
    • Can't resolve /fr/Apps/Build/Manipulating_media/HTML5_playbackRate_explained
    • and 5 more flaws omitted
  • translation_differences:
    • Differences in the important macros (1 in common of 7 possible)

URL: /fr/docs/Web/API/WebGL_API/Tutorial/Getting_started_with_WebGL
Title: Commencer avec WebGL
Flaw count: 5

  • broken_links:
    • Is currently http:// but can become https://
    • Is currently http:// but can become https://
    • Can't resolve /fr/HTML/Canvas
    • Is currently http:// but can become https://
    • Is currently http:// but can become https://

URL: /fr/docs/Web/API/WebGL_API/Tutorial/Using_shaders_to_apply_color_in_WebGL
Title: Ajouter des couleurs avec les nuanceurs
Flaw count: 1

  • broken_links:
    • Can't resolve /fr/docs/WebGL/Ajouter_du_contenu_à_WebGL

URL: /fr/docs/Web/API/WebGL_API/Tutorial/Adding_2D_content_to_a_WebGL_context
Title: Ajouter du contenu à WebGL
Flaw count: 3

  • macros:
    • /fr/docs/Web/API/WebGLRenderingContext/getShaderInfoLog does not exist but fell back to /en-US/docs/Web/API/WebGLRenderingContext/getShaderInfoLog
  • broken_links:
    • Is currently http:// but can become https://
    • Is currently http:// but can become https://

URL: /fr/docs/Web/API/WebGL_API/Tutorial/Using_textures_in_WebGL
Title: Utilisation des textures en WebGL
Flaw count: 3

  • broken_links:
    • Can't resolve /fr/docs/HTTP/Access_control_CORS
    • Is currently http:// but can become https://
    • Is currently http:// but can become https://

URL: /zh-TW/docs/Web/API/WebGL_API/Tutorial/Getting_started_with_WebGL
Title: WebGL 入門
Flaw count: 7

  • broken_links:
    • Is currently http:// but can become https://
    • Is currently http:// but can become https://
    • Can't resolve /zh-TW/docs/Learn/WebGL
    • Can use the English (en-US) link as a fallback
    • Can use the English (en-US) link as a fallback
    • and 2 more flaws omitted

URL: /zh-TW/docs/Web/API/WebGL_API/Tutorial/Adding_2D_content_to_a_WebGL_context
Title: 增加一個 2D 物件到 WebGL 環境
Flaw count: 5

  • macros:
    • /zh-TW/docs/Web/API/WebGLRenderingContext/createBuffer does not exist but fell back to /en-US/docs/Web/API/WebGLRenderingContext/createBuffer
    • /zh-TW/docs/Web/API/WebGLRenderingContext/bufferData does not exist but fell back to /en-US/docs/Web/API/WebGLRenderingContext/bufferData
    • /zh-TW/docs/Web/API/WebGLRenderingContext/drawArrays does not exist but fell back to /en-US/docs/Web/API/WebGLRenderingContext/drawArrays
  • broken_links:
    • Is currently http:// but can become https://
    • Is currently http:// but can become https://

URL: /ru/docs/Web/Guide/Audio_and_video_manipulation
Title: Обработка аудио и видео
Flaw count: 26

  • macros:
    • /ru/docs/Web/API/HTMLMediaElement/playbackRate does not exist but fell back to /en-US/docs/Web/API/HTMLMediaElement/playbackRate
    • /ru/docs/Web/API/AudioBufferSourceNode/playbackRate does not exist but fell back to /en-US/docs/Web/API/AudioBufferSourceNode/playbackRate
    • /ru/docs/Web/API/AudioDestinationNode does not exist but fell back to /en-US/docs/Web/API/AudioDestinationNode
    • /ru/docs/Web/API/AudioBufferSourceNode does not exist but fell back to /en-US/docs/Web/API/AudioBufferSourceNode
    • /ru/docs/Web/API/OscillatorNode does not exist but fell back to /en-US/docs/Web/API/OscillatorNode
    • and 5 more flaws omitted
  • broken_links:
    • Can't resolve /ru/docs/Web/WebGL
    • Can use the English (en-US) link as a fallback
    • Can't resolve /ru/docs/Web/WebGL
    • Can use the English (en-US) link as a fallback
    • Is currently http:// but can become https://
    • and 10 more flaws omitted
  • translation_differences:
    • Differences in the important macros (1 in common of 7 possible)

URL: /ru/docs/Web/API/WebGL_API/Tutorial/Lighting_in_WebGL
Title: Lighting in WebGL
Flaw count: 1

  • macros:
    • /ru/docs/Glossary/texel does not exist but fell back to /en-US/docs/Glossary/Texel

URL: /ru/docs/Web/API/WebGL_API/Tutorial/Using_textures_in_WebGL
Title: Using textures in WebGL
Flaw count: 7

  • macros:
    • /ru/docs/Web/API/WebGLRenderingContext/createTexture does not exist but fell back to /en-US/docs/Web/API/WebGLRenderingContext/createTexture
    • /ru/docs/Web/API/WebGLRenderingContext/texImage2D does not exist but fell back to /en-US/docs/Web/API/WebGLRenderingContext/texImage2D
    • /ru/docs/Web/API/WebGLRenderingContext/texImage2D does not exist but fell back to /en-US/docs/Web/API/WebGLRenderingContext/texImage2D
    • /ru/docs/Web/API/WebGLRenderingContext/texParameter does not exist but fell back to /en-US/docs/Web/API/WebGLRenderingContext/texParameter
  • broken_links:
    • Can use the English (en-US) link as a fallback
    • Is currently http:// but can become https://
    • Is currently http:// but can become https://

URL: /es/docs/Web/API/WebGL_API/Tutorial/Adding_2D_content_to_a_WebGL_context
Title: Agregando Contenido 2D en el Contexto WebGL
Flaw count: 6

  • macros:
    • /es/docs/Web/API/WebGLRenderingContext/createBuffer does not exist but fell back to /en-US/docs/Web/API/WebGLRenderingContext/createBuffer
    • /es/docs/Web/API/WebGLRenderingContext/bindBuffer does not exist but fell back to /en-US/docs/Web/API/WebGLRenderingContext/bindBuffer
    • /es/docs/Web/API/WebGLRenderingContext/bufferData does not exist but fell back to /en-US/docs/Web/API/WebGLRenderingContext/bufferData
    • /es/docs/Web/API/WebGLRenderingContext/drawArrays does not exist but fell back to /en-US/docs/Web/API/WebGLRenderingContext/drawArrays
  • broken_links:
    • Is currently http:// but can become https://
    • Is currently http:// but can become https://

URL: /es/docs/Web/API/WebGL_API/Tutorial/Using_textures_in_WebGL
Title: Utilizando texturas en WebGL
Flaw count: 10

  • macros:
    • /es/docs/Web/API/WebGLRenderingContext/createTexture does not exist but fell back to /en-US/docs/Web/API/WebGLRenderingContext/createTexture
    • /es/docs/Web/API/WebGLRenderingContext/texImage2D does not exist but fell back to /en-US/docs/Web/API/WebGLRenderingContext/texImage2D
    • /es/docs/Web/API/WebGLRenderingContext/generateMipMap does not exist but fell back to /en-US/docs/Web/API/WebGLRenderingContext/generateMipmap
    • /es/docs/Web/API/WebGLRenderingContext/texParameter does not exist but fell back to /en-US/docs/Web/API/WebGLRenderingContext/texParameter
    • /es/docs/Web/API/WebGLRenderingContext/bindTexture does not exist but fell back to /en-US/docs/Web/API/WebGLRenderingContext/bindTexture
  • broken_links:
    • Can't resolve /es/docs/Web/HTTP/Access_control_CORS
    • Can use the English (en-US) link as a fallback
    • Can't resolve /es/docs/Web/HTTP/Access_control_CORS
    • Is currently http:// but can become https://
    • Is currently http:// but can become https://

URL: /pt-BR/docs/Web/API/WebGL_API/Tutorial/Getting_started_with_WebGL
Title: Começando com WebGL
Flaw count: 5

  • broken_links:
    • Is currently http:// but can become https://
    • Is currently http:// but can become https://
    • Can use the English (en-US) link as a fallback
    • Is currently http:// but can become https://
    • Is currently http:// but can become https://

URL: /pt-BR/docs/Web/API/WebGL_API/Tutorial/Adding_2D_content_to_a_WebGL_context
Title: Adicionando conteúdo 2D a um contexto WebGL
Flaw count: 2

  • broken_links:
    • Is currently http:// but can become https://
    • Is currently http:// but can become https://
External URLs (25)

URL: /zh-CN/docs/Web/API/WebGL_API/Tutorial/Lighting_in_WebGL
Title: Lighting in WebGL

URL: /zh-CN/docs/Web/API/WebGL_API/Tutorial/Using_shaders_to_apply_color_in_WebGL
Title: 使用着色器将颜色应用于 WebGL

URL: /ja/docs/Web/Guide/Audio_and_video_manipulation
Title: 音声と動画の加工

URL: /ja/docs/Web/API/WebGL_API/Tutorial/Getting_started_with_WebGL
Title: WebGL 入門

URL: /ja/docs/Web/API/WebGL_API/Tutorial/Lighting_in_WebGL
Title: WebGL でのライティング

URL: /ja/docs/Web/API/WebGL_API/Tutorial/Using_shaders_to_apply_color_in_WebGL
Title: シェーダーを用いた WebGL での色の指定

URL: /ja/docs/Web/API/WebGL_API/Tutorial/Animating_objects_with_WebGL
Title: WebGL でのオブジェクトのアニメーティング

URL: /ja/docs/Web/API/WebGL_API/Tutorial/Using_textures_in_WebGL
Title: WebGL でのテクスチャの使用

URL: /fr/docs/Web/Guide/Audio_and_video_manipulation
Title: Manipulation Audio et Vidéo

URL: /fr/docs/Web/API/WebGL_API/Tutorial/Getting_started_with_WebGL
Title: Commencer avec WebGL

URL: /fr/docs/Web/API/WebGL_API/Tutorial/Lighting_in_WebGL
Title: Éclairage en WebGL

URL: /fr/docs/Web/API/WebGL_API/Tutorial/Using_shaders_to_apply_color_in_WebGL
Title: Ajouter des couleurs avec les nuanceurs

URL: /fr/docs/Web/API/WebGL_API/Tutorial/Adding_2D_content_to_a_WebGL_context
Title: Ajouter du contenu à WebGL

URL: /fr/docs/Web/API/WebGL_API/Tutorial/Animating_objects_with_WebGL
Title: Animer des objets avec WebGL

URL: /fr/docs/Web/API/WebGL_API/Tutorial/Using_textures_in_WebGL
Title: Utilisation des textures en WebGL

URL: /zh-TW/docs/Web/API/WebGL_API/Tutorial/Getting_started_with_WebGL
Title: WebGL 入門

URL: /zh-TW/docs/Web/API/WebGL_API/Tutorial/Adding_2D_content_to_a_WebGL_context
Title: 增加一個 2D 物件到 WebGL 環境

URL: /ru/docs/Web/Guide/Audio_and_video_manipulation
Title: Обработка аудио и видео

URL: /ru/docs/Web/API/WebGL_API/Tutorial/Lighting_in_WebGL
Title: Lighting in WebGL

URL: /ru/docs/Web/API/WebGL_API/Tutorial/Using_textures_in_WebGL
Title: Using textures in WebGL

URL: /es/docs/Web/API/WebGL_API/Tutorial/Using_shaders_to_apply_color_in_WebGL
Title: Utilizar los shaders para aplicar color en WebGL

URL: /es/docs/Web/API/WebGL_API/Tutorial/Adding_2D_content_to_a_WebGL_context
Title: Agregando Contenido 2D en el Contexto WebGL

URL: /es/docs/Web/API/WebGL_API/Tutorial/Using_textures_in_WebGL
Title: Utilizando texturas en WebGL

URL: /pt-BR/docs/Web/API/WebGL_API/Tutorial/Adding_2D_content_to_a_WebGL_context
Title: Adicionando conteúdo 2D a um contexto WebGL

(comment last updated: 2023-11-03 12:40:07)

@SphinxKnight SphinxKnight self-assigned this Oct 30, 2023
@Graywolf9 Graywolf9 requested review from Graywolf9 and removed request for Jalkhov October 30, 2023 18:27
@Graywolf9 Graywolf9 self-assigned this Oct 30, 2023
yin1999
yin1999 requested changes Oct 31, 2023
View reviewed changes
Copy link
Member

@yin1999 yin1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The URLs to source code seem to be wrong. Please fix them

files/zh-cn/web/api/webgl_api/tutorial/using_shaders_to_apply_color_in_webgl/index.md Outdated Show resolved Hide resolved
files/zh-tw/web/api/webgl_api/tutorial/adding_2d_content_to_a_webgl_context/index.md Outdated Show resolved Hide resolved
files/zh-tw/web/api/webgl_api/tutorial/getting_started_with_webgl/index.md Outdated Show resolved Hide resolved
files/zh-tw/web/api/webgl_api/tutorial/getting_started_with_webgl/index.md Outdated Show resolved Hide resolved
@yin1999 yin1999 removed the request for review from jasonren0403 October 31, 2023 15:09
@mikecat
Copy link
Contributor Author

mikecat commented Oct 31, 2023

@yin1999 Thank you for pointing out.

New fixes:

  • Replaced github.com/mdn/dom-examples/tree/main/webgl-examples/tree/gh-pages/ to github.com/mdn/dom-examples/tree/main/webgl-examples/ via TextSS.net
  • Manually fixed https://mdn.github.io/webgl-examples/ URLs to https://mdn.github.io/dom-examples/

Graywolf9
Graywolf9 approved these changes Oct 31, 2023
View reviewed changes
Copy link
Contributor

@Graywolf9 Graywolf9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much! LGTM for es

yin1999
yin1999 approved these changes Nov 1, 2023
View reviewed changes
Copy link
Member

@yin1999 yin1999 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mikecat. It looks good to me now (for l10n-zh)!

sashasushko
sashasushko approved these changes Nov 3, 2023
View reviewed changes
Copy link
Member

@sashasushko sashasushko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve for ru. Thanks 🤝

@yin1999 yin1999 removed the request for review from myshov November 3, 2023 10:22
SphinxKnight
SphinxKnight approved these changes Nov 3, 2023
View reviewed changes
Copy link
Member

@SphinxKnight SphinxKnight left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @mikecat! I've pushed a commit (strictly limited to fr) to fix some webgl related links on a page (which needs to be updated) and some videos URLs on another when the examples didn't work anymore.

Edit: OK for fr :)

josielrocha
josielrocha approved these changes Nov 5, 2023
View reviewed changes
Copy link
Collaborator

@josielrocha josielrocha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for pt-BR. 👍🏼!!

@yin1999 yin1999 removed the request for review from cw118 November 6, 2023 02:01
@yin1999
Copy link
Member

yin1999 commented Nov 6, 2023

ping @mdn/yari-content-ja :)

mfuji09
mfuji09 approved these changes Nov 6, 2023
View reviewed changes
Copy link
Collaborator

@mfuji09 mfuji09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for ja.

@mfuji09 mfuji09 merged commit 27299ea into mdn:main Nov 6, 2023
7 checks passed
@mikecat mikecat deleted the fix-webgl-example-link branch November 6, 2023 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yin1999 yin1999 yin1999 approved these changes

@Graywolf9 Graywolf9 Graywolf9 approved these changes

@mfuji09 mfuji09 mfuji09 approved these changes

@sashasushko sashasushko sashasushko approved these changes

@SphinxKnight SphinxKnight SphinxKnight approved these changes

@josielrocha josielrocha josielrocha approved these changes

@potappo potappo Awaiting requested review from potappo potappo is a code owner automatically assigned from mdn/yari-content-ja

Assignees

@SphinxKnight SphinxKnight

@Graywolf9 Graywolf9

Labels
l10n-es Issues related to Spanish content. l10n-fr Issues related to French content. l10n-ja Issues related to Japanese content. l10n-pt-br Issues related to Brazilian Portuguese l10n-ru Issues related to Russian content. l10n-zh Issues related to Chinese content.
Projects
l10n-fr
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@mikecat @yin1999 @josielrocha @SphinxKnight @sashasushko @mfuji09 @Graywolf9