Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): replace "fs-extra" with "node:fs/promise" #16911

Merged
merged 2 commits into from
Nov 24, 2023

Conversation

yin1999
Copy link
Member

@yin1999 yin1999 commented Nov 11, 2023

Description

As all the file system methods we used in this repo are available in "fs/promise", it would be ok to replace "fs-extra" and remove the dependency.

As all the file system methods we used in this repo are available in "fs/promise",
it would be ok to replace "fs-extra" and remove the dependency.
@github-actions github-actions bot added the system Infrastructure and configuration for the project label Nov 11, 2023
@yin1999 yin1999 marked this pull request as ready for review November 11, 2023 06:05
@yin1999 yin1999 requested a review from a team as a code owner November 11, 2023 06:05
@yin1999 yin1999 changed the title chore(deps): replace "fs-extra" with "fs/promise" chore(deps): replace "fs-extra" with "node:fs/promise" Nov 21, 2023
Copy link
Member Author

@yin1999 yin1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As this PR won't break those scripts, and used method are added in node:v10 (Meet our minimum node version requirements (v18)). I'm going to merge this

@yin1999 yin1999 merged commit e577923 into mdn:main Nov 24, 2023
8 of 9 checks passed
@yin1999 yin1999 deleted the update-redirects branch November 24, 2023 05:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
system Infrastructure and configuration for the project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant