Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove obsolete CanvasRenderingContext2D.currentTransform interface #16995

Merged
merged 5 commits into from
Nov 27, 2023
Merged

Remove obsolete CanvasRenderingContext2D.currentTransform interface #16995

merged 5 commits into from
Nov 27, 2023

Conversation

leon-win
Copy link
Member

@leon-win leon-win commented Nov 16, 2023 •
edited
Loading

Description

This PR remove next API members from MDN translated content:
CanvasRenderingContext2D.currentTransform
CanvasRenderingContext2D.mozCurrentTransform
CanvasRenderingContext2D.mozCurrentTransformInverse

Motivation

They has been removed from en-US locale a long time ago.

Related issues and pull requests

Relates to #13499, mdn/content#15294

@leon-win leon-win requested review from a team as code owners November 16, 2023 09:22
@leon-win leon-win requested review from lex111, SphinxKnight and clovislima and removed request for a team November 16, 2023 09:22
@github-actions github-actions bot added l10n-fr Issues related to French content. l10n-ru Issues related to Russian content. l10n-pt-br Issues related to Brazilian Portuguese labels Nov 16, 2023
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 16, 2023 •
edited
Loading

Preview URLs

Flaws (170)

URL: /pt-BR/docs/Web/API/CanvasRenderingContext2D
Title: Canvas: Contexto de Renderização em "2D"
Flaw count: 85

  • macros:
    • /pt-BR/docs/Web/API/TextMetrics does not exist but fell back to /en-US/docs/Web/API/TextMetrics
    • /pt-BR/docs/Web/API/CanvasRenderingContext2D/fillText does not exist but fell back to /en-US/docs/Web/API/CanvasRenderingContext2D/fillText
    • /pt-BR/docs/Web/API/CanvasRenderingContext2D/strokeText does not exist but fell back to /en-US/docs/Web/API/CanvasRenderingContext2D/strokeText
    • /pt-BR/docs/Web/API/CanvasRenderingContext2D/measureText does not exist but fell back to /en-US/docs/Web/API/CanvasRenderingContext2D/measureText
    • /pt-BR/docs/Web/API/TextMetrics does not exist but fell back to /en-US/docs/Web/API/TextMetrics
    • and 78 more flaws omitted
  • broken_links:
    • Is currently http:// but can become https://
  • translation_differences:
    • Differences in the important macros (3 in common of 4 possible)

URL: /fr/docs/Web/API/CanvasRenderingContext2D
Title: CanvasRenderingContext2D
Flaw count: 40

  • macros:
    • /fr/docs/Web/API/CanvasRenderingContext2D/lineWidth does not exist but fell back to /en-US/docs/Web/API/CanvasRenderingContext2D/lineWidth
    • /fr/docs/Web/API/CanvasRenderingContext2D/miterLimit does not exist but fell back to /en-US/docs/Web/API/CanvasRenderingContext2D/miterLimit
    • /fr/docs/Web/API/CanvasRenderingContext2D/getLineDash does not exist but fell back to /en-US/docs/Web/API/CanvasRenderingContext2D/getLineDash
    • /fr/docs/Web/API/CanvasRenderingContext2D/lineDashOffset does not exist but fell back to /en-US/docs/Web/API/CanvasRenderingContext2D/lineDashOffset
    • /fr/docs/Web/API/CanvasRenderingContext2D/createRadialGradient does not exist but fell back to /en-US/docs/Web/API/CanvasRenderingContext2D/createRadialGradient
    • and 33 more flaws omitted
  • broken_links:
    • Is currently http:// but can become https://
  • translation_differences:
    • Differences in the important macros (3 in common of 4 possible)

URL: /ru/docs/Web/API/CanvasRenderingContext2D
Title: CanvasRenderingContext2D
Flaw count: 45

  • macros:
    • /ru/docs/Web/API/TextMetrics does not exist but fell back to /en-US/docs/Web/API/TextMetrics
    • /ru/docs/Web/API/TextMetrics does not exist but fell back to /en-US/docs/Web/API/TextMetrics
    • /ru/docs/Web/API/CanvasRenderingContext2D/setLineDash does not exist but fell back to /en-US/docs/Web/API/CanvasRenderingContext2D/setLineDash
    • /ru/docs/Web/API/CanvasRenderingContext2D/direction does not exist but fell back to /en-US/docs/Web/API/CanvasRenderingContext2D/direction
    • /ru/docs/Web/API/CanvasRenderingContext2D/createRadialGradient does not exist but fell back to /en-US/docs/Web/API/CanvasRenderingContext2D/createRadialGradient
    • and 38 more flaws omitted
  • broken_links:
    • Is currently http:// but can become https://
  • translation_differences:
    • Differences in the important macros (3 in common of 4 possible)
External URLs (9)

URL: /pt-BR/docs/Web/API/CanvasRenderingContext2D
Title: Canvas: Contexto de Renderização em "2D"

URL: /fr/docs/Web/API/CanvasRenderingContext2D
Title: CanvasRenderingContext2D

URL: /ru/docs/Web/API/CanvasRenderingContext2D
Title: CanvasRenderingContext2D

(comment last updated: 2023-11-25 16:29:36)

@yin1999 yin1999 mentioned this pull request Nov 16, 2023
Open
@leon-win leon-win changed the title Remove CanvasRenderingContext2D.currentTransform from MDN translated content Remove CanvasRenderingContext2D.currentTransform from MDN translated content Nov 16, 2023
@leon-win leon-win changed the title Remove CanvasRenderingContext2D.currentTransform from MDN translated content Remove obsolete CanvasRenderingContext2D.currentTransform interface Nov 16, 2023
saionaro
saionaro approved these changes Nov 17, 2023
View reviewed changes
Copy link
Member

@saionaro saionaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for RU

@saionaro saionaro removed the request for review from lex111 November 17, 2023 09:24
josielrocha
josielrocha approved these changes Nov 19, 2023
View reviewed changes
Copy link
Collaborator

@josielrocha josielrocha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve for pt-BR

@yin1999 yin1999 removed the request for review from clovislima November 26, 2023 05:14
SphinxKnight
SphinxKnight approved these changes Nov 27, 2023
View reviewed changes
Copy link
Member

@SphinxKnight SphinxKnight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @leon-win and sorry for being late to the party. LGTM for fr

@SphinxKnight SphinxKnight merged commit 566a1a6 into mdn:main Nov 27, 2023
7 checks passed
@leon-win leon-win deleted the fix/13499/ru-macro-render-errors branch December 5, 2023 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saionaro saionaro saionaro approved these changes

@SphinxKnight SphinxKnight SphinxKnight approved these changes

@josielrocha josielrocha josielrocha approved these changes

Assignees
No one assigned
Labels
l10n-fr Issues related to French content. l10n-pt-br Issues related to Brazilian Portuguese l10n-ru Issues related to Russian content.
Projects
l10n-fr
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@leon-win @josielrocha @SphinxKnight @saionaro