Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[es] remove obsolete orphaned/Web/HTML/Element/blink #17123

Merged
merged 6 commits into from
Nov 28, 2023
Merged

[es] remove obsolete orphaned/Web/HTML/Element/blink #17123

merged 6 commits into from
Nov 28, 2023

Conversation

leon-win
Copy link
Member

@leon-win leon-win commented Nov 26, 2023 •
edited
Loading

Description

This PR removes obsolete orphaned/Web/HTML/Element/blink page in es locale.

Related issues and pull requests

Relates to mdn/content#26904

@leon-win leon-win requested a review from a team as a code owner November 26, 2023 17:55
@leon-win leon-win requested review from davbrito and removed request for a team November 26, 2023 17:55
@github-actions github-actions bot added the l10n-es Issues related to Spanish content. label Nov 26, 2023
Graywolf9
Graywolf9 requested changes Nov 27, 2023
View reviewed changes
Copy link
Contributor

@Graywolf9 Graywolf9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pending to see all the mentions

@github-actions github-actions bot added the merge conflicts 🚧 This pull request has merge conflicts that must be resolved. label Nov 27, 2023
@github-actions GitHub Actions
Copy link
Contributor

This pull request has merge conflicts that must be resolved before it can be merged.

@github-actions github-actions bot removed the merge conflicts 🚧 This pull request has merge conflicts that must be resolved. label Nov 27, 2023
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 27, 2023 •
edited
Loading

Preview URLs

Flaws (81)

URL: /es/docs/Web/JavaScript/Reference/Global_Objects/String
Title: String — Cadena de caracteres
Flaw count: 12

  • macros:
    • /es/docs/Web/JavaScript/Reference/Global_Objects/String/String does not exist but fell back to /en-US/docs/Web/JavaScript/Reference/Global_Objects/String/String
    • /es/docs/Web/JavaScript/Reference/Global_Objects/String/String does not exist but fell back to /en-US/docs/Web/JavaScript/Reference/Global_Objects/String/String
    • /es/docs/Web/JavaScript/Reference/Global_Objects/String/padEnd does not exist but fell back to /en-US/docs/Web/JavaScript/Reference/Global_Objects/String/padEnd
    • /es/docs/Web/JavaScript/Reference/Global_Objects/String/trimStart does not exist but fell back to /en-US/docs/Web/JavaScript/Reference/Global_Objects/String/trimStart
    • /es/docs/Web/JavaScript/Reference/Global_Objects/String/@@iterator does not exist but fell back to /en-US/docs/Web/JavaScript/Reference/Global_Objects/String/@@iterator
    • and 2 more flaws omitted
  • broken_links:
    • Can't resolve /es/docs/Web/JavaScript/Reference/Operators/String_Operators
    • Anchor not lowercase
    • Can use the English (en-US) link as a fallback
    • Can't resolve /es/Add-ons/Code_snippets/StringView
    • Can't resolve /es/docs/Web/API/DOMString/Binary

URL: /es/docs/Web/JavaScript/Reference/Global_Objects/String/blink
Title: String.prototype.blink()
Flaw count: 1

  • translation_differences:
    • Differences in the important macros (0 in common of 2 possible)

URL: /es/docs/Web/HTML/Element
Title: Referencia de Elementos HTML
Flaw count: 68

  • macros:
    • /es/docs/Web/HTML/Attributes/autocomplete does not exist but fell back to /en-US/docs/Web/HTML/Attributes/autocomplete
    • /es/docs/Web/HTML/Attributes/capture does not exist but fell back to /en-US/docs/Web/HTML/Attributes/capture
    • /es/docs/Web/HTML/Attributes/dirname does not exist but fell back to /en-US/docs/Web/HTML/Attributes/dirname
    • /es/docs/Web/HTML/Attributes/disabled does not exist but fell back to /en-US/docs/Web/HTML/Attributes/disabled
    • /es/docs/Web/HTML/Attributes/elementtiming does not exist but fell back to /en-US/docs/Web/HTML/Attributes/elementtiming
    • and 41 more flaws omitted
  • broken_links:
    • Can't resolve /en/Sections_and_Outlines_of_an_HTML5_document#sectioning_root
    • Can't resolve /es/HTML/Element/article
    • Can't resolve /es/HTML/Element/aside
    • Can't resolve /es/HTML/Element/nav
    • Can't resolve /es/HTML/Element/section
    • and 16 more flaws omitted
  • translation_differences:
    • Differences in the important macros (0 in common of 2 possible)

(comment last updated: 2023-11-28 18:35:00)

@leon-win
Copy link
Member Author

Pending to see all the mentions

I modified this PR, now I have definitely removed all occurrences of the blink =)

Graywolf9
Graywolf9 approved these changes Nov 28, 2023
View reviewed changes
Copy link
Contributor

@Graywolf9 Graywolf9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much!

@Graywolf9 Graywolf9 merged commit ac6e6ca into mdn:main Nov 28, 2023
7 checks passed
@leon-win leon-win deleted the remove/es-orphaned-web-html-element-blink branch November 28, 2023 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Graywolf9 Graywolf9 Graywolf9 approved these changes

@davbrito davbrito Awaiting requested review from davbrito davbrito is a code owner automatically assigned from mdn/yari-content-es

Assignees
No one assigned
Labels
l10n-es Issues related to Spanish content.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@leon-win @Graywolf9