-
Notifications
You must be signed in to change notification settings - Fork 8.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(ja): content clean up for markdown-lint-cli bump #17239
Conversation
Preview URLs (27 pages)
Flaws (280)Note! 7 documents with no flaws that don't need to be listed. 🎉 URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
External URLs (3)URL: URL: URL:
(comment last updated: 2023-12-09 01:39:37) |
This pull request has merge conflicts that must be resolved before it can be merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yin1999
Thank you! I noticed about two changes.
@@ -35,7 +35,7 @@ create() と get() メソッドが全体像の中でどのように位置づけ | |||
|
|||
![ウェブ認証 API のコンポーネントの登録とデータフロー図](webauthn_registration_r4.png) | |||
|
|||
_図 1 - ウェブ認証による登録手順と各アクションに関連する重要なデータの流れを示す図_ | |||
_図 1 - ウェブ認証による登録手順と各アクションに関連する重要なデータの流れを示す図。_ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We usually omit the last punctation for a caption of a diagram.
_図 1 - ウェブ認証による登録手順と各アクションに関連する重要なデータの流れを示す図。_ | |
_図 1 - ウェブ認証による登録手順と各アクションに関連する重要なデータの流れを示す図_ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @mfuji09. This would cause the "Emphasis used instead of a heading" error with the new version of markdown lint if the whole sentence is emphasized without the tailing punctuation.
As the en-US document has removed the sentence. Is it okay if I add the ignore expression (<!-- markdownlint-disable -->
) to this sentence for now (in a future update to this article, we can remove the ignore expression)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in 48e4765
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Co-authored-by: Masahiro FUJIMOTO <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you!
Description
content clean up for markdown-lint-cli bump
Since I can't speak Japanese, so feel free to correct any mistake in this PR.
Related issues and pull requests
prepare for: #17042
config ref: #15106