Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(actions): ko-locale label email noti webhooks #22445

Closed
wants to merge 2 commits into from

Conversation

1ilsang
Copy link
Member

@1ilsang 1ilsang commented Jul 16, 2024

Description

Suggestions for receiving notifications about issues assigned to the ko-locale team. (Email, Discord, etc..) There is currently no way to receive notifications.

Send a notification when the l10n-ko label is attached.

This PR is related to #22297

cc. @mdn/yari-content-ko

Motivation

Email content:

The above issue was recently published under [ko] label.

I haven't received any emails/notifications regarding this, so I'm leaving an inquiry because I'm curious about how other people can check.

If you need to check it manually, it would be a good idea to add our team mention to the ko issue template itself.

Additional details

I do not have permission to set the following secrets, so you need to set this.

image

Related issues and pull requests

Relates to #22297

@1ilsang 1ilsang requested a review from a team as a code owner July 16, 2024 15:55
@github-actions github-actions bot added the system Infrastructure and configuration for the project label Jul 16, 2024
@1ilsang
Copy link
Member Author

1ilsang commented Jul 16, 2024

@hochan222

작업하면서 고민되는 부분이 하나 있었는데요,

디스코드 웹훅은 별도의 아이디가 필요하지 않나요? 관리 포인트가 얼마나 있는지 궁금합니다.

메일 방식을 살펴보니 Gmail 계정 생성부터 관리가 필요해 장기적으로 좋을지 조금 의문입니다. 🤔

만약 디스코드 방식의 관리 포인트가 크지 않다면 디스코드로 하는게 나을 수도 있다고 생각되네요.

Details

Gmail 2024 정책으로, gmail 계정에 메일을 보내는 모든 발신자는 해당 정책을 따라야 합니다.

별도 메일 서버를 구축하지 않기 때문에 공용 gmail 계정을 생성하는 편이 제일 쉬운 길로 보여 계정 생성후 토큰을 만들었습니다.

이 과정에서 제 개인 휴대폰으로 2FA가 등록되어 있어 조금 걱정이네요

@1ilsang
Copy link
Member Author

1ilsang commented Jul 30, 2024

We decide to use Discord. Close the PR.

@1ilsang 1ilsang closed this Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
system Infrastructure and configuration for the project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant