Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[zh-cn] init translation of html attribute required #22801

Merged
merged 6 commits into from
Aug 9, 2024
Merged

[zh-cn] init translation of html attribute required #22801

merged 6 commits into from
Aug 9, 2024

Conversation

jasonren0403
Copy link
Contributor

Description

part of #17632

Motivation

Additional details

Related issues and pull requests

@jasonren0403 jasonren0403 requested a review from a team as a code owner July 30, 2024 03:08
@jasonren0403 jasonren0403 requested review from t7yang and removed request for a team July 30, 2024 03:08
@github-actions github-actions bot added the l10n-zh Issues related to Chinese content. label Jul 30, 2024
@jasonren0403 jasonren0403 mentioned this pull request Jul 30, 2024
Open
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 30, 2024 •
edited
Loading

Preview URLs

Flaws (12)

URL: /zh-CN/docs/Web/HTML/Attributes/required
Title: HTML 属性：required
Flaw count: 12

  • macros:
    • /zh-CN/docs/Web/HTML/Attributes/accept does not exist but fell back to /en-US/docs/Web/HTML/Attributes/accept
    • /zh-CN/docs/Web/HTML/Attributes/dirname does not exist but fell back to /en-US/docs/Web/HTML/Attributes/dirname
    • /zh-CN/docs/Web/HTML/Attributes/elementtiming does not exist but fell back to /en-US/docs/Web/HTML/Attributes/elementtiming
    • /zh-CN/docs/Web/HTML/Attributes/max does not exist but fell back to /en-US/docs/Web/HTML/Attributes/max
    • /zh-CN/docs/Web/HTML/Attributes/maxlength does not exist but fell back to /en-US/docs/Web/HTML/Attributes/maxlength
    • and 6 more flaws omitted
  • translation_differences:
    • Differences in the important macros (1 in common of 3 possible)

(comment last updated: 2024-08-09 01:19:42)

yin1999
yin1999 reviewed Jul 30, 2024
View reviewed changes
Copy link
Member

@yin1999 yin1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions:

files/zh-cn/web/html/attributes/required/index.md Outdated Show resolved Hide resolved
files/zh-cn/web/html/attributes/required/index.md Outdated Show resolved Hide resolved
files/zh-cn/web/html/attributes/required/index.md Outdated

{{HTMLElement("input/range", "range")}} 和 {{HTMLElement("input/color", "color")}} 不支持该属性，也与之无关，因为两者都有默认值。{{HTMLElement("input/hidden", "hidden")}} 也不支持该属性，因为用户不可能填写隐藏的表单。也不支持任何按钮类型，包括 `image`。

注意，`color` 和 `range` 也不支持 `required`，因为它们都总是有一个值。`color` 类型默认为 `#000000`。`range` 的默认值是 `min` 和 `max` 之间的中点，如果没有声明，在大多数浏览器中，`min` 和 `max` 的默认值分别是 0 和 100。
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Somewhat duplicated with the previous paragraph, could you fix it in mdn/content first :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Somewhat duplicated with the previous paragraph, could you fix it in mdn/content first :)

proposed mdn/content#35318

files/zh-cn/web/html/attributes/required/index.md Outdated Show resolved Hide resolved
files/zh-cn/web/html/attributes/required/index.md Outdated Show resolved Hide resolved
files/zh-cn/web/html/attributes/required/index.md Outdated Show resolved Hide resolved
@yin1999 yin1999 enabled auto-merge (squash) August 9, 2024 01:18
@yin1999 yin1999 merged commit 379e4e5 into main Aug 9, 2024
8 checks passed
@yin1999 yin1999 deleted the html-required-zhcn branch August 9, 2024 01:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yin1999 yin1999 yin1999 approved these changes

@t7yang t7yang Awaiting requested review from t7yang t7yang is a code owner automatically assigned from mdn/yari-content-zh

Assignees
No one assigned
Labels
l10n-zh Issues related to Chinese content.
Projects
MDN translated-content l10n-zh
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jasonren0403 @yin1999