Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update root-cert-stats to use runtime.sendMessage #542

Closed
rebloor opened this issue Oct 1, 2023 · 3 comments · Fixed by #547
Closed

Update root-cert-stats to use runtime.sendMessage #542

rebloor opened this issue Oct 1, 2023 · 3 comments · Fixed by #547
Labels
effort: medium This task is a medium effort. example New or updated example good first issue A good issue for newcomers to get started with. help wanted If you know something about this topic, we would love your help! p2 We want to address this but may have other higher priority items.

Comments

@rebloor
Copy link
Collaborator

rebloor commented Oct 1, 2023

What information was incorrect, unhelpful, or incomplete?

This example use getBackgroundPage(). It's bad practice to use getBackgroundPage(), e.g. in a private browsing window that logic breaks. If you can fix the example to use what I just described, it would be great.

What did you expect to see?

This example should use runtime.sendMessage from popup.js + runtime.onMessage in the background page to send the data back.

Do you have any supporting links, references, or citations?

See #536 (comment)

Do you have anything more you want to share?

No response
@rebloor rebloor added the needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. label Oct 1, 2023
@github-actions
Copy link

github-actions bot commented Oct 1, 2023

It looks like this is your first issue. Welcome! 👋 One of the project maintainers will be with you as soon as possible. We appreciate your patience. To safeguard the health of the project, please take a moment to read our code of conduct.

@rebloor rebloor added help wanted If you know something about this topic, we would love your help! good first issue A good issue for newcomers to get started with. effort: medium This task is a medium effort. p2 We want to address this but may have other higher priority items. example New or updated example and removed needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. labels Oct 1, 2023
@ibzimh
Copy link
Contributor

ibzimh commented Oct 30, 2023

can i be assigned to this?

@ibzimh ibzimh mentioned this issue Oct 30, 2023
Merged
@ibzimh
Copy link
Contributor

ibzimh commented Oct 30, 2023

I've submitted a PR for this #547

rebloor added a commit that referenced this issue Nov 4, 2023
@ibzimh @Rob--W @rebloor
Update root-cert-stats to use runtime.sendMessage #542 (#547)
faadfca 
* Adding send message and on message functions

* moving table displaying into a new function

* updating rootCertStats from var to let

* updating comments

* Apply Linter change, unused const

Co-authored-by: Rob Wu <[email protected]>

---------

Co-authored-by: Rob Wu <[email protected]>
Co-authored-by: rebloor <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
effort: medium This task is a medium effort. example New or updated example good first issue A good issue for newcomers to get started with. help wanted If you know something about this topic, we would love your help! p2 We want to address this but may have other higher priority items.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update root-cert-stats to use runtime.sendMessage #542 ibzimh/webextensions-examples
2 participants
@rebloor @ibzimh