Update root-cert-stats to use runtime.sendMessage #542 #547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this is your first pull request. 🎉 Thank you for your contribution! One of the project maintainers will triage and assign the pull request for review. We appreciate your patience. To safeguard the health of the project, please take a moment to read our code of conduct. |
|
@rpl I have exercised and confirmed the code appears to work as expected. |
Rob--W
approved these changes
Oct 31, 2023
Rob--W
reviewed
Nov 2, 2023
Co-authored-by: Rob Wu <[email protected]>
|
Congratulations on your first merged pull request. 🎉 Thank you for your contribution! Did you know we have a project board with high-impact contribution opportunities? We look forward to your next contribution. |
|
@ibzimh many thanks for your help on this one |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for Issue: Update root-cert-stats to use runtime.sendMessage #542
Description
I've added functionality for
runtime.sendMessageandruntime.onMessageand it works on my browser. I had to move the table displaying into a different function; i thought it would be easier to read than to put it in the response callback function.If there's something which is incorrect or should be changed, let me know!
Related issues and pull requests
"Fixes #542"