Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump inquirer from 9.3.4 to 10.0.0 #11432

Merged
merged 2 commits into from
Jul 9, 2024

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jul 8, 2024

Bumps inquirer from 9.3.4 to 10.0.0.

Release notes

Sourced from inquirer's releases.

[email protected]

  • Re-implemented with Typescript.
  • Adding CJS support (now inquirer is publishes a dual-build CJS/ESM.)
  • All core prompts are now coming from @inquirer/prompt.
  • Custom prompts now should be implemented with @inquirer/core. Custom prompts built on [email protected] will keep working, but should plan a migration.
  • inquirer.ui.BottomBar is deleted.

My expectation is that this release should be a drop-in replacement for people using inquirer.prompt() and built-ins 🤞🏻. Please open an issue on Github if you run into issues migrating; it's a large rewrite and there might be a few sharp edges to cut! Hope you'll like this new release.

[email protected]

  • Fix issue with plugins relying on internal inquirer packages file structure.
Commits
  • a9ee70f Publish
  • 22ae264 Feat(inquirer): Replace core prompts with the new @​inquirer/prompts
  • 6ec598b Major(inquirer): Migrate to Typescript and dual module package
  • 093c565 Publish
  • f7e6186 Test: Unify integration tests styles with other tests
  • dc4c1ef Update inquirer tests to not rely on mocking internals
  • 13b9543 Fix(inquirer): Revert inquirer@v9 export changes
  • 85a3d40 Chore(tools): Support multiple exports declaration in package.json
  • See full diff in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [inquirer](https://github.com/SBoudrias/Inquirer.js) from 9.3.4 to 10.0.0.
- [Release notes](https://github.com/SBoudrias/Inquirer.js/releases)
- [Commits](https://github.com/SBoudrias/Inquirer.js/compare/[email protected]@10.0.0)

---
updated-dependencies:
- dependency-name: inquirer
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot requested a review from mdn-bot as a code owner July 8, 2024 11:34
@dependabot dependabot bot added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code labels Jul 8, 2024
@caugner caugner requested review from a team and removed request for mdn-bot July 9, 2024 09:46
@caugner
Copy link
Contributor

caugner commented Jul 9, 2024

FYI @SBoudrias In order to upgrade from inquirer v9 to v10, we had to specify the types, see this commit.

@caugner caugner merged commit 52d63db into main Jul 9, 2024
16 checks passed
@caugner caugner deleted the dependabot/npm_and_yarn/inquirer-10.0.0 branch July 9, 2024 10:44
@SBoudrias
Copy link

Thanks for the headsup! I did reviewed some types yesterday and released 10.0.1, I was able to get some better inferring of the return types. Let me know if you can try it out! 😄

ferdnyc pushed a commit to ferdnyc/yari that referenced this pull request Jul 13, 2024
* chore(deps): bump inquirer from 9.3.4 to 10.0.0
* chore(deps): specify inquirer prompt type

Co-authored-by: Claas Augner <[email protected]>
@caugner
Copy link
Contributor

caugner commented Jul 22, 2024

Let me know if you can try it out! 😄

@SBoudrias Thanks, updating to 10.0.1 was no problem, but 10.0.2/10.0.3 caused a couple of new TypeScript errors. Note that we have been using inquirer directly, and it seems that using @inquirer/prompts is the recommended way now, so we're migrating there. This was not obvious to me from the release notes, but maybe this has changed in an earlier release and we just missed it. Anyways, the new interface looks much nicer, thanks! 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants