Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(community): new community page design #11653

Open
wants to merge 29 commits into
base: main
Choose a base branch
from
Open

feat(community): new community page design #11653

wants to merge 29 commits into from

Conversation

LeoMcA
Copy link
Member

@LeoMcA LeoMcA commented Aug 19, 2024

Summary

https://mozilla-hub.atlassian.net/browse/MP-1369

  • Implements the new design, and uses a markdown file to power the content
  • Markdown -> JSON build step not implemented, done by copying the markdown file into curriculum, building that, then copying the json back out and manually fixing it up
  • We'll implement this build step in rari separately

How did you test this change?

  • yarn dev and yarn render:html
  • tested across :3000 and :5042
  • tested across breakpoints
  • tested across light/dark mode

@LeoMcA LeoMcA requested a review from a team as a code owner August 19, 2024 14:10
@github-actions github-actions bot added the copy Copy changes to hard-coded texts on the site label Aug 19, 2024
@github-actions github-actions bot added python Pull requests that update Python code deployer Deployment (currently using AWS S3 and AWS Lambda) labels Aug 20, 2024
@github-actions github-actions bot added the merge conflicts 🚧 Please rebase onto or merge the latest main. label Sep 6, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 6, 2024

This pull request has merge conflicts that must be resolved before it can be merged.

@github-actions github-actions bot removed the merge conflicts 🚧 Please rebase onto or merge the latest main. label Sep 6, 2024
caugner
caugner reviewed Sep 9, 2024
View reviewed changes
deployer/src/deployer/search/__init__.py
@@ -217,8 +217,8 @@ def to_search(file, _index=None):
return
doc = data["doc"]

if doc["mdn_url"].startswith("/en-US/curriculum/"):
# Skip curriculum content for now.
if "/docs/" not in doc["mdn_url"]:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this really work?

@github-actions github-actions bot added the dependencies Pull requests that update a dependency file label Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caugner caugner caugner left review comments

@mdn-bot mdn-bot Awaiting requested review from mdn-bot mdn-bot is a code owner

Assignees
No one assigned
Labels
copy Copy changes to hard-coded texts on the site dependencies Pull requests that update a dependency file deployer Deployment (currently using AWS S3 and AWS Lambda) python Pull requests that update Python code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LeoMcA @caugner @fiji-flo