-
Notifications
You must be signed in to change notification settings - Fork 501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(syntax-highlight): do client side #11654
base: main
Are you sure you want to change the base?
Conversation
This pull request has merge conflicts that must be resolved before it can be merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
This pull request has merge conflicts that must be resolved before it can be merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great. Let's see how it performs in prod.
Deploying to stage: https://github.com/mdn/yari/actions/runs/10792160559 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM, left some comments.
This pull request has merge conflicts that must be resolved before it can be merged. |
Summary
Problem
Syntax highlighting in the content build system clutters our API, and would require porting to rari
Solution
Do it client side
Also fixes e.g. vue pages having examples with a
MARKUP
headerHow did you test this change?
yarn dev
<pre>
s