Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): pin cheerio to 1.0.0-rc.12 #11752

Merged
merged 1 commit into from
Sep 6, 2024
Merged

Conversation

caugner
Copy link
Contributor

@caugner caugner commented Sep 6, 2024

Summary

Fixes #11618.

Problem

We required cheerio via ^1.0.0-rc.12, but this version range includes the latest 1.0.0 version, which has some breaking changes and we won't upgrade to it.

Solution

Pin cheerio to the specific 1.0.0-rc.12 version instead.


How did you test this change?

Trivial change.

@github-actions github-actions bot added the dependencies Pull requests that update a dependency file label Sep 6, 2024
Copy link
Contributor Author

@caugner caugner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Self-approval, because the change is trivial.

@caugner caugner merged commit 722b130 into main Sep 6, 2024
15 checks passed
@caugner caugner deleted the 11618-pin-cheerio-version branch September 6, 2024 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make Yari compatible with cheerio 1.0.0
1 participant