fix(sidebar): reuse icon margin for non-nested entries #11786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caugner
force-pushed
the
11614-fix-icon-margin-in-sidebar
branch
from
848bdf4
to
024b7fd
Compare
|
The test failure is unrelated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #11614.
Problem
The non-standard and deprecated icons were missing a margin for non-nested sidebar list items.
Solution
Generalize the corresponding style for all sidebar list items.
Screenshots
How did you test this change?
Ran
yarn devlocally and checked http://localhost:3000/en-US/docs/Web/API/PaymentAddress.