chore(server): clean-up #11968
Merged
chore(server): clean-up #11968
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Bundle StatsHey there, this message comes from a github action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
fiji-flo
commented
Oct 16, 2024
| @@ -250,7 +250,7 @@ app.get("/*", async (req, res) => { | |||
| console.log(`Don't know how to mock: ${req.path}`, req.query); | |||
| res | |||
| .status(404) | |||
| .sendFile(path.join(STATIC_ROOT, "en-us", "_spas", "404.html")); | |||
| .sendFile(path.join(BUILD_OUT_ROOT, "en-us", "_spas", "404.html")); | |||
There was a problem hiding this comment.
This was wrong all along. The SPAs end up in BUILD_OUT_ROOT which happens to have the same default as STATIC_ROOT...
LeoMcA
reviewed
Oct 16, 2024
server/index.ts
Outdated
| } | ||
| res.header("Content-Security-Policy", CSP_VALUE); | ||
| return res.send(renderHTML(doc)); |
There was a problem hiding this comment.
I don't think doc has a url key, does it?
There was a problem hiding this comment.
Indeed, the old world.
LeoMcA
reviewed
Oct 17, 2024
LeoMcA
approved these changes
Oct 25, 2024
server/index.ts
Outdated
| toc: __, | ||
| sidebarHTML: ___, | ||
| ...builtMetadata | ||
| } = (doc.doc as any) || {}; |
There was a problem hiding this comment.
Best to not, do we need the || {}? doc.doc should be defined according to the types, and if it's not, we might as well blow everything up:
Suggested change
| } = (doc.doc as any) || {}; | |
| } = (doc.doc); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Refactor routes for the dev-server.
Problem
The routes are rather messy.
Solution
Start grouping things better.
This PR:
into a separate route.
How did you test this change?
yarn dev