Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(placement): fix on site search #12029

Merged
merged 3 commits into from
Oct 25, 2024
Merged

fix(placement): fix on site search #12029

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b4058c2
fix(placement): fix on site search
fiji-flo Oct 24, 2024
2934d2e
fix padding
fiji-flo Oct 25, 2024
df42bb7
Merge branch 'main' into fix-placement-on-site-search
fiji-flo Oct 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion client/src/site-search/index.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,12 +8,16 @@
.site-search {
display: block;

article {
.main-content {
@media (max-width: $screen-md) {
display: flex;
flex-direction: column;
}

article {
display: contents;
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it's a good idea to have this article here behave differently then other articles on MDN.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noted, this basically affects the main-page-content class. It only affects padding/margin. But this was the least minimal invasive change.


.place {
float: right;
padding: 1rem;
Expand Down
2 changes: 1 addition & 1 deletion client/src/site-search/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,8 +56,8 @@ export function SiteSearch() {
return (
<div className="main-wrapper site-search">
<MainContentContainer>
<SidePlacement />
<article className="main-page-content">
<SidePlacement />
{query ? (
<h1>
Search results for: <span className="query-string">{query}</span>{" "}
Expand Down
Loading