chore(baseline): add glean metrics #9391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add data-glean attribute that can be set on anchors - for now, leaving buttons and the other data attributes as they are - we might want to remove and migrate them to data-glean in the future
Rumyra
approved these changes
Aug 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Problem
We have no engagement metrics with Baseline.
Solution
Add glean pings for:
Also added and use
data-gleanattribute, rather than throwinggleanClicks on the anchors, at @fiji-flo's suggestion.We can migrate buttons and the other data attributes later.
How did you test this change?
set
ran
yarn devobserved correct looking glean pings appearing in my console:
https://debug-ping-preview.firebaseapp.com/pings/mdn-dev/be83388b-96a8-49a3-836e-b0fcdc1fcae9
https://debug-ping-preview.firebaseapp.com/pings/mdn-dev/e639dcbe-5991-4ada-8acb-a82671581575
https://debug-ping-preview.firebaseapp.com/pings/mdn-dev/5a087c91-49fb-49bc-ab4d-a798be8d50c2