Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(macros): delete {{spec|spec2|SpecName}} macros #9982

Merged
merged 1 commit into from
Nov 9, 2023

Conversation

yin1999
Copy link
Member

@yin1999 yin1999 commented Nov 9, 2023

Summary

We have removed spec, spec2, SpecName macros from translated-content. It's time to remove them from yari.


How did you test this change?

Search those macros in mdn/translated-content:

rg -i "\{\{\s*spec[^i]"

result (the occurrences are only plain texts, we could remove them after updating the en-US document)

files/zh-cn/mdn/writing_guidelines/howto/json_structured_data/index.md
120:`\{{SpecName}}` 和 `\{{Spec2}}` 宏使用 `SpecData.json` 文件。我们不再接受对 `SpecData.json` 文件的任何进一步的贡献;相反,要么尝试使用 `\{{Specifications}}` 宏插入一个规范表格,要么尝试硬编码直接指向规范的链接。请注意,大多数情况下,在*规范*部分之外提及或链接到规范表明 MDN 上未适当记录某些内容。

files/es/mdn/writing_guidelines/howto/json_structured_data/index.md
122:Las macros `\{{SpecName}}` y `\{{Spec2}}` que estamos eliminando utilizan el archivo `SpecData.json`. No aceptamos más contribuciones al archivo `SpecData.json`; en su lugar, intente insertar una tabla de especificaciones, utilizando la macro `\{{Specifications}}`, o intente codificar el enlace (bueno) a la especificación. Tenga en cuenta que la mayoría de las veces, mencionar o vincular a una especificación fuera de la sección _Especificaciones_ es un signo de algo que no está debidamente documentado en MDN.

@yin1999 yin1999 requested a review from a team as a code owner November 9, 2023 01:33
@github-actions github-actions bot added the macros tracking issues related to kumascript macros label Nov 9, 2023
Copy link
Contributor

@teoli2003 teoli2003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having created these (at least Spec2 and SpecName) more than a decade ago, I'm delighted to see them disappear. They made their time.

Congratulations to all the l10n contributors that made this possible: there were thousands (even ten of thousands!) occurence of these in translated-content.

🎉

@caugner
Copy link
Contributor

caugner commented Nov 9, 2023

Thank you! Verified locally using the macro-usage-report that all occurrences have been removed except for the MDN Writing Guidelines. 👍

@caugner caugner merged commit 4cfbb82 into mdn:main Nov 9, 2023
9 checks passed
@yin1999 yin1999 deleted the remove-spec branch November 9, 2023 13:12
gurezo pushed a commit to gurezo/yari that referenced this pull request Nov 11, 2023
gurezo pushed a commit to gurezo/yari that referenced this pull request Nov 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
macros tracking issues related to kumascript macros
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants