Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated shape derivative reference values #232

Merged
merged 1 commit into from
Sep 30, 2022
Merged

Updated shape derivative reference values #232

merged 1 commit into from
Sep 30, 2022

Conversation

sseraj
Copy link
Collaborator

@sseraj sseraj commented Sep 29, 2022

Purpose

This PR updates some of the shape derivative reference values for the adjoint test. This is needed because the changes to the point projection in mdolab/pyspline#47 changed some the geometric derivatives by slightly more than the tolerance.

Expected time until merged

The tests will fail without the pySpline changes, so this PR should be merged at the same time as mdolab/pyspline#47.

Type of change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (non-backwards-compatible fix or feature)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Documentation update
  • Maintenance update
  • Other (please describe)

Testing

Checklist

  • I have run flake8 and black to make sure the Python code adheres to PEP-8 and is consistently formatted
  • I have formatted the Fortran code with fprettify or C/C++ code with clang-format as applicable
  • I have run unit and regression tests which pass locally with my changes
  • I have added new tests that prove my fix is effective or that my feature works
  • I have added necessary documentation

@sseraj sseraj requested a review from a team as a code owner September 29, 2022 22:38
@codecov
Copy link

codecov bot commented Sep 29, 2022

Codecov Report

Merging #232 (6162443) into main (b3ed666) will decrease coverage by 12.49%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             main     #232       +/-   ##
===========================================
- Coverage   41.35%   28.86%   -12.50%     
===========================================
  Files          13       13               
  Lines        3794     3794               
===========================================
- Hits         1569     1095      -474     
- Misses       2225     2699      +474     
Impacted Files Coverage Δ
adflow/pyADflow.py 47.04% <0.00%> (-21.38%) ⬇️
adflow/MExt.py 78.94% <0.00%> (-18.43%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@anilyil anilyil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for this. The current azure failures are pretty much exactly the offsets I am getting w/o this PR but with the new changes in pyspline. The tests pass for me with the latest pyspline in the PR and with these references

@ewu63 ewu63 merged commit 5cc177e into main Sep 30, 2022
@ewu63 ewu63 deleted the embed-ref branch September 30, 2022 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants