Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the failed GHA build #58

Merged
merged 1 commit into from
Dec 10, 2023
Merged

Fix the failed GHA build #58

merged 1 commit into from
Dec 10, 2023

Conversation

eytanadler
Copy link
Collaborator

Purpose

The recent GitHub Actions build failed, I believe because of something to do with the OpenAeroStruct online surrogate model component. My hunch is that, because the training data is generated in parallel with separate OpenMDAO Problems, the parallel problems are overwriting each other's reports. I turned off reports for these problems to hopefully fix it.

Type of change

What types of change is it?
Select the appropriate type(s) that describe this PR

  • Bugfix (non-breaking change which fixes an issue)

Testing

Explain the steps needed to test the new code to verify that it does indeed address the issue and produce the expected behavior.

Checklist

Put an x in the boxes that apply.

  • I have run unit and regression tests which pass locally with my changes
  • I have added new tests that prove my fix is effective or that my feature works
  • I have added necessary documentation

@eytanadler eytanadler requested a review from a team as a code owner December 9, 2023 20:01
Copy link

codecov bot commented Dec 9, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6c90acb) 79.99% compared to head (bf69d98) 79.99%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #58   +/-   ##
=======================================
  Coverage   79.99%   79.99%           
=======================================
  Files          85       85           
  Lines        9297     9297           
=======================================
  Hits         7437     7437           
  Misses       1860     1860           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eytanadler eytanadler merged commit 4fc037d into mdolab:main Dec 10, 2023
13 checks passed
@eytanadler eytanadler deleted the fix_build branch December 10, 2023 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants