Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
The compressible duct with the heat exchanger included (
ImplicitCompressibleDuct
rather thanImplicitCompressibleDuct_ExternalHX
) did not have working connections. I think they were probably not updated after other components had been changed or added to the one with the external HX. I've changed them so they match the external heat exchanger one.I also realized that the pyCycle tests are not run GitHub Actions because pyCycle is not installed. I added the latest version to the install and fixed an outdated pyCycle option in the tests.
Type of change
What types of change is it?
Select the appropriate type(s) that describe this PR
Testing
Explain the steps needed to test the new code to verify that it does indeed address the issue and produce the expected behavior.
Checklist
Put an
x
in the boxes that apply.