-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changed Hx Value error to Analysis error for 3 instances. #62
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #62 +/- ##
==========================================
+ Coverage 79.95% 79.98% +0.03%
==========================================
Files 85 85
Lines 9300 9300
==========================================
+ Hits 7436 7439 +3
+ Misses 1864 1861 -3 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you Marie! Let's get #61 merged first, then we can merge this one and make a new release for version 1.1.2.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mariejvaucher Could you fix the conflicts in the import lines? Other than that, looks good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @mariejvaucher!
Purpose
Previously the script was raising a Python ValueError that wasn't caught by OM solvers. Now the error is an OM Analysis Error which allows the solver to continue optimization and also gives details about which value is wrong and why.
Type of change
Testing
Added new tests
Checklist
Put an
x
in the boxes that apply.